comparison libpurple/protocols/yahoo/libymsg.c @ 28122:b6a9e2079d50

Use PURPLE_CONNECTION_ERROR_NETWORK_ERROR as the connection error reason, which will allow libpurple's auto-reconnect to handle the reconnection instead of forcing it in the prpl

28121:c499a1e8ceff

	char *msg;
	char *url = NULL;
	char *fullmsg;
	PurpleAccount *account = gc->account;
	PurpleConnectionError reason = PURPLE_CONNECTION_ERROR_OTHER_ERROR;
	gboolean reconnect = FALSE;

	while (l) {
		struct yahoo_pair *pair = l->data;

		if (pair->key == 66)

		reason = PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED;
		break;
	case 52:
		/* See #9660. As much as we know, reconnecting shouldn't hurt */
		purple_debug_info("yahoo", "Got error 52, Set to autoreconnect\n");
		reconnect = TRUE;
		msg = g_strdup_printf(_("Unknown error"));
		break;
	case 1013:
		msg = g_strdup(_("Invalid username"));
		reason = PURPLE_CONNECTION_ERROR_INVALID_USERNAME;
		break;

		fullmsg = g_strdup(msg);

	purple_connection_error_reason(gc, reason, fullmsg);
	g_free(msg);
	g_free(fullmsg);

	/* In case of error 52, we reconnect */
	if(reconnect)
		purple_account_connect(account);
}

static void yahoo_process_addbuddy(PurpleConnection *gc, struct yahoo_packet *pkt)
{
	int err = 0;

28122:b6a9e2079d50

	char *msg;
	char *url = NULL;
	char *fullmsg;
	PurpleAccount *account = gc->account;
	PurpleConnectionError reason = PURPLE_CONNECTION_ERROR_OTHER_ERROR;

	while (l) {
		struct yahoo_pair *pair = l->data;

		if (pair->key == 66)

		reason = PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED;
		break;
	case 52:
		/* See #9660. As much as we know, reconnecting shouldn't hurt */
		purple_debug_info("yahoo", "Got error 52, Set to autoreconnect\n");
		msg = g_strdup_printf(_("Unknown error"));
		reason = PURPLE_CONNECTION_ERROR_NETWORK_ERROR;
		break;
	case 1013:
		msg = g_strdup(_("Invalid username"));
		reason = PURPLE_CONNECTION_ERROR_INVALID_USERNAME;
		break;

		fullmsg = g_strdup(msg);

	purple_connection_error_reason(gc, reason, fullmsg);
	g_free(msg);
	g_free(fullmsg);
}

static void yahoo_process_addbuddy(PurpleConnection *gc, struct yahoo_packet *pkt)
{
	int err = 0;