comparison pidgin/gtkblist.c @ 21400:cb9e962d4f7f

Fix iterating over accounts_signed_on_elsewhere while doing things that will cause it to change.

21399:d2bd7eae1c2c

static void
ignore_elsewhere_accounts(PidginBuddyList *gtkblist)
{
	PidginBuddyListPrivate *priv = PIDGIN_BUDDY_LIST_GET_PRIVATE(gtkblist);
	GList *l;

	for (l = priv->accounts_signed_on_elsewhere; l != NULL; l = l->next) {
		PurpleAccount *account = l->data;
		purple_account_clear_current_error(account);
	}

	g_list_free(priv->accounts_signed_on_elsewhere);
	priv->accounts_signed_on_elsewhere = NULL;

	destroy_signed_on_elsewhere_minidialog(priv);
}

static GtkWidget *

21400:cb9e962d4f7f

static void
ignore_elsewhere_accounts(PidginBuddyList *gtkblist)
{
	PidginBuddyListPrivate *priv = PIDGIN_BUDDY_LIST_GET_PRIVATE(gtkblist);
	GList *accounts_elsewhere, *l;

	/* priv->accounts_signed_on_elsewhere gets changed in
	 * update_account_error_state, which is called when
	 * purple_account_clear_current_error emits account-error-changed. So
	 * let's take a copy.
	 *
	 * (Or maybe we could just use while(priv->accounts_elsewhere) and rely
	 * on it being ultimately reduced to NULL?  But that sounds fragile.)
	 */
	accounts_elsewhere = g_list_copy(priv->accounts_signed_on_elsewhere);

	for (l = accounts_elsewhere; l != NULL; l = l->next)
	{
		PurpleAccount *account = l->data;
		purple_account_clear_current_error(account);
	}

	g_list_free(accounts_elsewhere);

	destroy_signed_on_elsewhere_minidialog(priv);
}

static GtkWidget *