comparison src/protocols/gg/gg.c @ 12641:e0e8b0735c5a

[gaim-migrate @ 14977] A change from Bartosz Oler. I think this is intended to hide blocked as a status that one can set on themself. Anyway, this is all wrong, so I added some comments to that effect. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Fri, 23 Dec 2005 12:02:01 +0000
parents 851b0bd7eb52
children fc28451f5d96
comparison
equal deleted inserted replaced
12640:de306144dc8a 12641:e0e8b0735c5a
1450 GAIM_STATUS_AWAY, "busy", _("Busy"), TRUE, TRUE, FALSE, 1450 GAIM_STATUS_AWAY, "busy", _("Busy"), TRUE, TRUE, FALSE,
1451 "message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), 1451 "message", _("Message"), gaim_value_new(GAIM_TYPE_STRING),
1452 NULL); 1452 NULL);
1453 types = g_list_append(types, type); 1453 types = g_list_append(types, type);
1454 1454
1455 /* Why is blocked a status??? -- rlaager */ 1455 /* This status is wrong. It shouldn't exist. This prpl must not be
1456 * using the privacy stuff correctly. -- rlaager */
1456 type = gaim_status_type_new_with_attrs( 1457 type = gaim_status_type_new_with_attrs(
1457 GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, TRUE, FALSE, 1458 GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, FALSE, FALSE,
1458 "message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), NULL); 1459 "message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), NULL);
1459 types = g_list_append(types, type); 1460 types = g_list_append(types, type);
1460 1461
1461 return types; 1462 return types;
1462 } 1463 }
1473 1474
1474 act = gaim_blist_node_action_new(_("Add to chat"), 1475 act = gaim_blist_node_action_new(_("Add to chat"),
1475 ggp_bmenu_add_to_chat, NULL, NULL); 1476 ggp_bmenu_add_to_chat, NULL, NULL);
1476 m = g_list_append(m, act); 1477 m = g_list_append(m, act);
1477 1478
1479 /* Using a blist node boolean here is also wrong.
1480 * Once the Block and Unblock actions are added to the core,
1481 * this will have to go. -- rlaager */
1478 if (gaim_blist_node_get_bool(node, "blocked")) { 1482 if (gaim_blist_node_get_bool(node, "blocked")) {
1479 act = gaim_blist_node_action_new(_("Unblock"), 1483 act = gaim_blist_node_action_new(_("Unblock"),
1480 ggp_bmenu_block, NULL, NULL); 1484 ggp_bmenu_block, NULL, NULL);
1481 } else { 1485 } else {
1482 act = gaim_blist_node_action_new(_("Block"), 1486 act = gaim_blist_node_action_new(_("Block"),