Mercurial > pidgin.yaz

comparison src/gtkconv.c @ 12600:e856f985a0b9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 14934] Enable the extra warnings regardless of --enable-debug. Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure. Enable (well, stop disabling) the missing initializer warnings. This leads to warnings with: GValue v = {0,}; that must be worked around. Basically, instead of: GValue v = {0,}; ... g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */ We'd need to do: GValue v; ... v.g_type = 0; g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */ Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future. While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together. Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined. committer: Tailor Script <tailor@pidgin.im>
author Richard Laager <rlaager@wiktel.com>
date Wed, 21 Dec 2005 18:36:19 +0000
parents 3d34460ecfd6
children e63fb8e9f4ac
comparison
equal deleted inserted replaced
12599:e94c33909aa6 12600:e856f985a0b9
2502 } 2502 }
2503 2503
2504 static GtkItemFactoryEntry menu_items[] = 2504 static GtkItemFactoryEntry menu_items[] =
2505 { 2505 {
2506 /* Conversation menu */ 2506 /* Conversation menu */
2507 { N_("/_Conversation"), NULL, NULL, 0, "<Branch>" }, 2507 { N_("/_Conversation"), NULL, NULL, 0, "<Branch>", NULL },
2508 2508
2509 { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, 2509 { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb,
2510 0, "<StockItem>", GAIM_STOCK_IM }, 2510 0, "<StockItem>", GAIM_STOCK_IM },
2511 2511
2512 { "/Conversation/sep0", NULL, NULL, 0, "<Separator>" }, 2512 { "/Conversation/sep0", NULL, NULL, 0, "<Separator>", NULL },
2513 2513
2514 { N_("/Conversation/_Find..."), NULL, menu_find_cb, 0, 2514 { N_("/Conversation/_Find..."), NULL, menu_find_cb, 0,
2515 "<StockItem>", GTK_STOCK_FIND }, 2515 "<StockItem>", GTK_STOCK_FIND },
2516 { N_("/Conversation/View _Log"), NULL, menu_view_log_cb, 0, "<StockItem>", GAIM_STOCK_LOG }, 2516 { N_("/Conversation/View _Log"), NULL, menu_view_log_cb, 0, "<StockItem>", GAIM_STOCK_LOG },
2517 { N_("/Conversation/_Save As..."), NULL, menu_save_as_cb, 0, 2517 { N_("/Conversation/_Save As..."), NULL, menu_save_as_cb, 0,
2518 "<StockItem>", GTK_STOCK_SAVE_AS }, 2518 "<StockItem>", GTK_STOCK_SAVE_AS },
2519 { N_("/Conversation/Clea_r"), "<CTL>L", menu_clear_cb, 0, "<StockItem>", GTK_STOCK_CLEAR }, 2519 { N_("/Conversation/Clea_r"), "<CTL>L", menu_clear_cb, 0, "<StockItem>", GTK_STOCK_CLEAR },
2520 2520
2521 { "/Conversation/sep1", NULL, NULL, 0, "<Separator>" }, 2521 { "/Conversation/sep1", NULL, NULL, 0, "<Separator>", NULL },
2522 2522
2523 { N_("/Conversation/Se_nd File..."), NULL, menu_send_file_cb, 0, "<StockItem>", GAIM_STOCK_FILE_TRANSFER }, 2523 { N_("/Conversation/Se_nd File..."), NULL, menu_send_file_cb, 0, "<StockItem>", GAIM_STOCK_FILE_TRANSFER },
2524 { N_("/Conversation/Add Buddy _Pounce..."), NULL, menu_add_pounce_cb, 2524 { N_("/Conversation/Add Buddy _Pounce..."), NULL, menu_add_pounce_cb,
2525 0, "<StockItem>", GAIM_STOCK_POUNCE }, 2525 0, "<StockItem>", GAIM_STOCK_POUNCE },
2526 { N_("/Conversation/_Get Info"), "<CTL>O", menu_get_info_cb, 0, 2526 { N_("/Conversation/_Get Info"), "<CTL>O", menu_get_info_cb, 0,
2527 "<StockItem>", GAIM_STOCK_INFO }, 2527 "<StockItem>", GAIM_STOCK_INFO },
2528 { N_("/Conversation/In_vite..."), NULL, menu_invite_cb, 0, 2528 { N_("/Conversation/In_vite..."), NULL, menu_invite_cb, 0,
2529 "<StockItem>", GAIM_STOCK_INVITE }, 2529 "<StockItem>", GAIM_STOCK_INVITE },
2530 2530
2531 { "/Conversation/sep2", NULL, NULL, 0, "<Separator>" }, 2531 { "/Conversation/sep2", NULL, NULL, 0, "<Separator>", NULL },
2532 2532
2533 { N_("/Conversation/Al_ias..."), NULL, menu_alias_cb, 0, 2533 { N_("/Conversation/Al_ias..."), NULL, menu_alias_cb, 0,
2534 "<StockItem>", GAIM_STOCK_EDIT }, 2534 "<StockItem>", GAIM_STOCK_EDIT },
2535 { N_("/Conversation/_Block..."), NULL, menu_block_cb, 0, 2535 { N_("/Conversation/_Block..."), NULL, menu_block_cb, 0,
2536 "<StockItem>", GAIM_STOCK_BLOCK }, 2536 "<StockItem>", GAIM_STOCK_BLOCK },
2537 { N_("/Conversation/_Add..."), NULL, menu_add_remove_cb, 0, 2537 { N_("/Conversation/_Add..."), NULL, menu_add_remove_cb, 0,
2538 "<StockItem>", GTK_STOCK_ADD }, 2538 "<StockItem>", GTK_STOCK_ADD },
2539 { N_("/Conversation/_Remove..."), NULL, menu_add_remove_cb, 0, 2539 { N_("/Conversation/_Remove..."), NULL, menu_add_remove_cb, 0,
2540 "<StockItem>", GTK_STOCK_REMOVE }, 2540 "<StockItem>", GTK_STOCK_REMOVE },
2541 2541
2542 { "/Conversation/sep3", NULL, NULL, 0, "<Separator>" }, 2542 { "/Conversation/sep3", NULL, NULL, 0, "<Separator>", NULL },
2543 2543
2544 { N_("/Conversation/Insert Lin_k..."), NULL, menu_insert_link_cb, 0, 2544 { N_("/Conversation/Insert Lin_k..."), NULL, menu_insert_link_cb, 0,
2545 "<StockItem>", GAIM_STOCK_LINK }, 2545 "<StockItem>", GAIM_STOCK_LINK },
2546 { N_("/Conversation/Insert Imag_e..."), NULL, menu_insert_image_cb, 0, 2546 { N_("/Conversation/Insert Imag_e..."), NULL, menu_insert_image_cb, 0,
2547 "<StockItem>", GAIM_STOCK_IMAGE }, 2547 "<StockItem>", GAIM_STOCK_IMAGE },
2548 2548
2549 { "/Conversation/sep4", NULL, NULL, 0, "<Separator>" }, 2549 { "/Conversation/sep4", NULL, NULL, 0, "<Separator>", NULL },
2550 2550
2551 { N_("/Conversation/_Close"), NULL, menu_close_conv_cb, 0, 2551 { N_("/Conversation/_Close"), NULL, menu_close_conv_cb, 0,
2552 "<StockItem>", GTK_STOCK_CLOSE }, 2552 "<StockItem>", GTK_STOCK_CLOSE },
2553 2553
2554 /* Options */ 2554 /* Options */
2555 { N_("/_Options"), NULL, NULL, 0, "<Branch>" }, 2555 { N_("/_Options"), NULL, NULL, 0, "<Branch>", NULL },
2556 { N_("/Options/Enable _Logging"), NULL, menu_logging_cb, 0, "<CheckItem>" }, 2556 { N_("/Options/Enable _Logging"), NULL, menu_logging_cb, 0, "<CheckItem>", NULL },
2557 { N_("/Options/Enable _Sounds"), NULL, menu_sounds_cb, 0, "<CheckItem>" }, 2557 { N_("/Options/Enable _Sounds"), NULL, menu_sounds_cb, 0, "<CheckItem>", NULL },
2558 { N_("/Options/Show Buddy _Icon"), NULL, menu_buddyicon_cb, 0, "<CheckItem>" }, 2558 { N_("/Options/Show Buddy _Icon"), NULL, menu_buddyicon_cb, 0, "<CheckItem>", NULL },
2559 { "/Options/sep0", NULL, NULL, 0, "<Separator>" }, 2559 { "/Options/sep0", NULL, NULL, 0, "<Separator>", NULL },
2560 { N_("/Options/Show Formatting _Toolbars"), NULL, menu_toolbar_cb, 0, "<CheckItem>" }, 2560 { N_("/Options/Show Formatting _Toolbars"), NULL, menu_toolbar_cb, 0, "<CheckItem>", NULL },
2561 { N_("/Options/Show Ti_mestamps"), "F2", menu_timestamps_cb, 0, "<CheckItem>" }, 2561 { N_("/Options/Show Ti_mestamps"), "F2", menu_timestamps_cb, 0, "<CheckItem>", NULL },
2562 }; 2562 };
2563 2563
2564 static const int menu_item_count = 2564 static const int menu_item_count =
2565 sizeof(menu_items) / sizeof(*menu_items); 2565 sizeof(menu_items) / sizeof(*menu_items);
2566 2566