comparison pidgin/plugins/musicmessaging/musicmessaging.c @ 15786:e926951e61fe

Don't use g_list_length() and g_slist_length() when all you want to do if check if the list is empty. Those two functions needlessly iterate through the entire list.

15785:eed84b59c252

static int
mmconv_from_conv_loc(GaimConversation *conv)
{
	MMConversation *mmconv_current = NULL;
	guint i;
	
	for (i = 0; i < g_list_length(conversations); i++)
	{
		mmconv_current = (MMConversation *)g_list_nth_data(conversations, i);
		if (conv == mmconv_current->conv)
		{
			return i;
		}
	}
	return -1;
}

static MMConversation*

static gboolean
plugin_unload(GaimPlugin *plugin) {
	MMConversation *mmconv = NULL;
	
	while (g_list_length(conversations) > 0)
	{
		mmconv = g_list_first(conversations)->data;
		conv_destroyed(mmconv->conv);
	}
	return TRUE;
}

15786:e926951e61fe

static int
mmconv_from_conv_loc(GaimConversation *conv)
{
	GList *l;
	MMConversation *mmconv_current = NULL;
	guint i;
	
	i = 0;
	for (l = conversations; l != NULL; l = l->next)
	{
		mmconv_current = l->data;
		if (conv == mmconv_current->conv)
		{
			return i;
		}
		i++;
	}
	return -1;
}

static MMConversation*

static gboolean
plugin_unload(GaimPlugin *plugin) {
	MMConversation *mmconv = NULL;
	
	while (conversations != NULL)
	{
		mmconv = conversations->data;
		conv_destroyed(mmconv->conv);
	}
	return TRUE;
}