Mercurial > pidgin.yaz

comparison pidgin/gtkblist.c @ 24497:f10aba5592c6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
The other day while struct hiding, I noticed a for loop that was checking g_list_length() as the loop conditional. I decided to check all our calls to g_list_length() to see which ones I could clean up without too much work.
author Richard Laager <rlaager@wiktel.com>
date Thu, 27 Nov 2008 05:54:09 +0000
parents 558523cebd10
children 125cac3e24ee fdd9fd5c2086 9bdd3ab8087f 25e2ab1fff1d a063901a5499 89b95d143116
comparison
equal deleted inserted replaced
24496:cd70713a996d 24497:f10aba5592c6
3318 char *tmp; 3318 char *tmp;
3319 3319
3320 if (PURPLE_BLIST_NODE_IS_CHAT(node)) 3320 if (PURPLE_BLIST_NODE_IS_CHAT(node))
3321 { 3321 {
3322 PurpleChat *chat; 3322 PurpleChat *chat;
3323 GList *connections;
3323 GList *cur; 3324 GList *cur;
3324 struct proto_chat_entry *pce; 3325 struct proto_chat_entry *pce;
3325 char *name, *value; 3326 char *name, *value;
3326 PurpleConversation *conv; 3327 PurpleConversation *conv;
3327 PidginBlistNode *bnode = node->ui_data; 3328 PidginBlistNode *bnode = node->ui_data;
3328 3329
3329 chat = (PurpleChat *)node; 3330 chat = (PurpleChat *)node;
3330 prpl = purple_find_prpl(purple_account_get_protocol_id(chat->account)); 3331 prpl = purple_find_prpl(purple_account_get_protocol_id(chat->account));
3331 prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl); 3332 prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
3332 3333
3333 if (g_list_length(purple_connections_get_all()) > 1) 3334 connections = purple_connections_get_all();
3335 if (connections && connections->next)
3334 { 3336 {
3335 tmp = g_markup_escape_text(chat->account->username, -1); 3337 tmp = g_markup_escape_text(chat->account->username, -1);
3336 g_string_append_printf(str, _("<b>Account:</b> %s"), tmp); 3338 g_string_append_printf(str, _("<b>Account:</b> %s"), tmp);
3337 g_free(tmp); 3339 g_free(tmp);
3338 } 3340 }
3398 */ 3400 */
3399 PurpleContact *c; 3401 PurpleContact *c;
3400 PurpleBuddy *b; 3402 PurpleBuddy *b;
3401 PurplePresence *presence; 3403 PurplePresence *presence;
3402 PurpleNotifyUserInfo *user_info; 3404 PurpleNotifyUserInfo *user_info;
3405 GList *connections;
3403 char *tmp; 3406 char *tmp;
3404 time_t idle_secs, signon; 3407 time_t idle_secs, signon;
3405 3408
3406 if (PURPLE_BLIST_NODE_IS_CONTACT(node)) 3409 if (PURPLE_BLIST_NODE_IS_CONTACT(node))
3407 { 3410 {
3419 3422
3420 presence = purple_buddy_get_presence(b); 3423 presence = purple_buddy_get_presence(b);
3421 user_info = purple_notify_user_info_new(); 3424 user_info = purple_notify_user_info_new();
3422 3425
3423 /* Account */ 3426 /* Account */
3424 if (full && g_list_length(purple_connections_get_all()) > 1) 3427 connections = purple_connections_get_all();
3428 if (full && connections && connections->next)
3425 { 3429 {
3426 tmp = g_markup_escape_text(purple_account_get_username( 3430 tmp = g_markup_escape_text(purple_account_get_username(
3427 purple_buddy_get_account(b)), -1); 3431 purple_buddy_get_account(b)), -1);
3428 purple_notify_user_info_add_pair(user_info, _("Account"), tmp); 3432 purple_notify_user_info_add_pair(user_info, _("Account"), tmp);
3429 g_free(tmp); 3433 g_free(tmp);