Mercurial > pidgin.yaz
comparison libgaim/protocols/msn/switchboard.c @ 14278:f71894e1700d
[gaim-migrate @ 16963]
Fix a crazy bug that we found at meebo. I'm not sure it
affects gtk Gaim in quite the same way, but what was
happeing is that the conversation sequence number should
be incremented by 1 each time a new conversation is
created (whether created by someone else or created by
you). However, in one place in Gaim conv_seq was being
incremented BEFORE it was used and in another it was
being incremented AFTER it was used. This can lead to
a sequence number being used twice.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 21 Aug 2006 22:50:58 +0000 |
parents | 60b1bc8dbf37 |
children | 21509d8e4e70 |
comparison
equal
deleted
inserted
replaced
14277:06f03f2bc6c6 | 14278:f71894e1700d |
---|---|
250 * switchboard we're in the middle of using :( */ | 250 * switchboard we're in the middle of using :( */ |
251 if (swboard->conv != NULL) | 251 if (swboard->conv != NULL) |
252 gaim_conversation_destroy(swboard->conv); | 252 gaim_conversation_destroy(swboard->conv); |
253 #endif | 253 #endif |
254 | 254 |
255 cmdproc->session->conv_seq++; | 255 swboard->chat_id = cmdproc->session->conv_seq++; |
256 swboard->chat_id = cmdproc->session->conv_seq; | |
257 swboard->flag |= MSN_SB_FLAG_IM; | 256 swboard->flag |= MSN_SB_FLAG_IM; |
258 swboard->conv = serv_got_joined_chat(account->gc, | 257 swboard->conv = serv_got_joined_chat(account->gc, |
259 swboard->chat_id, | 258 swboard->chat_id, |
260 "MSN Chat"); | 259 "MSN Chat"); |
261 | 260 |