diff pidgin/pidgin.h @ 24987:17b840986607

GTK+ 2.16.0 will set the invisible character to a nice bullet instead of an asterisk, which has been the default up until now. So we should stop setting the invisible character ourselves in GTK+ 2.16.0 and higher. The comment in pidgin.h is cool because it talks about stuff that hasn't happened yet in the past tense.
author Mark Doliner <mark@kingant.net>
date Sat, 24 Jan 2009 02:19:14 +0000
parents b5e35cce4f85
children 087419df2cfe
line wrap: on
line diff
--- a/pidgin/pidgin.h	Sat Jan 24 02:02:25 2009 +0000
+++ b/pidgin/pidgin.h	Sat Jan 24 02:19:14 2009 +0000
@@ -91,11 +91,22 @@
 #define PIDGIN_HIG_BORDER        12
 #define PIDGIN_HIG_BOX_SPACE      6
 
+#if !GTK_CHECK_VERSION(2,16,0)
 /*
- * See GNOME bug #307304 for some discussion about the invisible
- * character.  0x25cf is a good choice, too.
+ * Older version of GNOME defaulted to using an asterisk as the invisible
+ * character.  But this is ugly and we want to use something nicer.
+ *
+ * The default invisible character was changed in Gnome revision 21446
+ * (GTK+ 2.16) from an asterisk to the first available character out of
+ * 0x25cf, 0x2022, 0x2731, 0x273a.  See GNOME bugs 83935 and 307304 for
+ * discussion leading up to the change.
+ *
+ * Here's the change:
+ * http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=21446
+ *
  */
-#define PIDGIN_INVISIBLE_CHAR (gunichar)0x2022
+#define PIDGIN_INVISIBLE_CHAR (gunichar)0x25cf
+#endif /* Less than GTK+ 2.16 */
 
 #endif /* _PIDGIN_H_ */