diff src/protocols/msn/slpmsg.c @ 10306:56cc5d49472b

[gaim-migrate @ 11492] " Well, I found a bug, and even though I had code to prevent that crash it seems it did not. So now here is in a different way, which by the way is more efficient." --Felipe Contreras (19:35:44) shx: LSchiere: there's a bugfix patch for msn in the tracker if it interest you ;) (19:35:59) LSchiere: the one i assigned to nosnilmot just a little bit ago? (19:36:24) shx: LSchiere: probably (19:38:25) LSchiere: i just remembered to day is release day (19:38:51) shx: yeap... so I tought it was important to commit it also, i rather like being able to compile committer: Tailor Script <[e-mail]>

--- a/src/protocols/msn/slpmsg.c	Fri Dec 03 00:10:19 2004 +0000
+++ b/src/protocols/msn/slpmsg.c	Fri Dec 03 00:57:21 2004 +0000
@@ -65,21 +65,29 @@
 
 	if (slpmsg->msg != NULL)
 	{
+		/* Something is pointing to this slpmsg, so we should remove that
+		 * pointer to prevent a crash. */
+		/* Ex: a user goes offline and after that we receive an ACK */
+
+		gaim_debug_info("msn", "Unlink slpmsg callbacks.\n");
+
+		slpmsg->msg->ack_cb = NULL;
+		slpmsg->msg->ack_data = NULL;
+
+#if 0
 		MsnTransaction *trans;
 
 		trans = slpmsg->msg->trans;
 
 		if (trans != NULL)
 		{
-			/* Something is pointing to this slpmsg, so we should remove that
-			 * pointer to prevent a crash. */
-
 			if (trans->callbacks != NULL && trans->has_custom_callbacks)
 				g_hash_table_destroy(trans->callbacks);
 			
 			trans->callbacks = NULL;
 			trans->data = NULL;
 		}
+#endif
 	}
 
 	slplink->slp_msgs =