diff libpurple/protocols/msn/servconn.c @ 24329:6e4979001d6d

The "processing" flag basically says "this connection is busy, don't destroy it yet, wait until it's done processing." I don't think there's any reason for us to set processing to TRUE just because we're connecting. I think this is a holdover from before our purple_proxy_connect() could be canceled. But now that it's cancelable, if we want to kill the connection we can cleanly cancel the connect without worrying about the callback being triggered.

--- a/libpurple/protocols/msn/servconn.c	Wed Nov 12 08:58:27 2008 +0000
+++ b/libpurple/protocols/msn/servconn.c	Wed Nov 12 09:10:29 2008 +0000
@@ -239,15 +239,7 @@
 	servconn->connect_data = purple_proxy_connect(NULL, session->account,
 			host, port, connect_cb, servconn);
 
-	if (servconn->connect_data != NULL)
-	{
-		servconn->processing = TRUE;
-		return TRUE;
-	}
-	else
-	{
-		return FALSE;
-	}
+	return (servconn->connect_data != NULL);
 }
 
 void