Mercurial > pidgin.yaz

diff src/protocols/msn/msn.c @ 10069:7cbe12859d3a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[gaim-migrate @ 11045] " msn_act_id() checks the length of the string it is passed to ensure that it is less than BUDDY_ALIAS_MAXLEN before attempting to send the command to the server. However, it checks the string before encoding it so if you pass a string that becomes longer than BUDDY_ALIAS_MAXLEN after encoding it then MSN will drop the connection when attempting to update your friendly name. Patch is for cvs head. I also have a patch for 1.0.0, if interested." --dbattams patch okayed by shx committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Wed, 29 Sep 2004 01:53:36 +0000
parents f948913f3c33
children 9d839c9f6c2d
line wrap: on
line diff
--- a/src/protocols/msn/msn.c	Tue Sep 28 00:22:47 2004 +0000
+++ b/src/protocols/msn/msn.c	Wed Sep 29 01:53:36 2004 +0000
@@ -107,7 +107,10 @@
 	cmdproc = session->notification->cmdproc;
 	account = gaim_connection_get_account(gc);
 
-	alias = (entry && *entry) ? entry : "";
+	if(entry && strlen(entry))
+		alias = gaim_url_encode(entry);
+	else
+		alias = "";
 
 	if (strlen(alias) > BUDDY_ALIAS_MAXLEN)
 	{
@@ -118,7 +121,7 @@
 
 	msn_cmdproc_send(cmdproc, "REA", "%s %s",
 					 gaim_account_get_username(account),
-					 gaim_url_encode(alias));
+					 alias);
 }
 
 static void