diff src/server.c @ 6245:9083f92e0d58

[gaim-migrate @ 6739] this should really fix the infinite looping in server.c that KingAnt tried to fix. gaim_find_buddy() behaves like it used to now, and gaim_find_buddies() must be used to get all matching buddies committer: Tailor Script <[e-mail]>

--- a/src/server.c	Sun Jul 20 14:11:43 2003 +0000
+++ b/src/server.c	Sun Jul 20 16:19:31 2003 +0000
@@ -1019,6 +1019,7 @@
 {
 	GaimAccount *account;
 	struct buddy *b;
+	GSList *buddies;
 
 	account = gaim_connection_get_account(gc);
 	b = gaim_find_buddy(account, name);
@@ -1129,21 +1130,12 @@
 			gaim_pounce_execute(gc->account, b->name, GAIM_POUNCE_SIGNOFF);
 			system_log(log_signoff, gc, b, OPT_LOG_BUDDY_SIGNON);
 		}
-	}	
-	
+	}
+
 	gaim_blist_update_buddy_presence(b, loggedin);
 
-	/*
-	 * Now, update the rest of the buddies in the list.  This is weird, by 
-	 * the way.  Basically we call gaim_find_buddy() until it returns null.  
-	 * Calling gaim_find_buddy() with a name sets a static variable.  Then 
-	 * calling it without a name uses that static reference to return other 
-	 * stuff.  We can't be sure that the above code didn't call 
-	 * gaim_find_buddy() again with another buddy name, so we "reseed" the 
-	 * function here.
-	 */
-	b = gaim_find_buddy(account, name);
-	while ((b = gaim_find_buddy(gc->account, NULL)) != NULL) {
+	for (buddies = gaim_find_buddies(account, name); buddies; buddies = g_slist_remove(buddies, buddies->data)) {
+		b = buddies->data;
 		gaim_blist_update_buddy_presence(b, loggedin);
 		gaim_blist_update_buddy_idle(b, idle);
 		gaim_blist_update_buddy_evil(b, evil);