Mercurial > pidgin.yaz
diff src/module.c @ 4249:9c7fcb211886
[gaim-migrate @ 4499]
If anyone is curious, the commit before this fixed a bug which
didn't allow you to delete AIM or ICQ people from a deny list.
They'll show up when you sign back online, and will be deleteable
now.
This is a patch from the good Mr. McQueen.
"Twofold attack:
1) Make sure all the callback functions don't throw a mental if the gc
the dialog was asking about has disappeared. Make sure the functions
still free up the data structs as necessary in this case.
2) When setting up a ask dialog, plugins (including prpls) pass in their
handle. The ask dialog struct gets kept in a slist. When unloading a
plugin or prpl, Gaim checks the handle against the list, and sends a
cancel-type message for any outstanding dialogs.
Should avoid crashes from non-modal ask dialogs lying around."
Yeah, so that's a nice lil' improvement.
I also fixed a think where SSI "authorization denied" messages
would be gibberish. That was a bug from just a few hours ago.
Whoops.
Also, since this is like a grown up version of show and tell, I
thought this was funny:
* Robot101 fixes idiocy
<KingAnt> Does that mean I'm going to be nuetered?
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 08 Jan 2003 08:18:49 +0000 |
parents | 4927f8dd046f |
children | 24d2881f75d2 |
line wrap: on
line diff
--- a/src/module.c Wed Jan 08 07:28:54 2003 +0000 +++ b/src/module.c Wed Jan 08 08:18:49 2003 +0000 @@ -284,6 +284,9 @@ debug_printf("Unloading %s\n", g_module_name(p->handle)); + /* cancel any pending dialogs the plugin has */ + do_ask_cancel_by_handle(p->handle); + /* Attempt to call the plugin's remove function (if there) */ if (g_module_symbol(p->handle, "gaim_plugin_remove", (gpointer *)&gaim_plugin_remove)) gaim_plugin_remove(); @@ -325,6 +328,9 @@ debug_printf("Unloading %s\n", g_module_name(p->handle)); + /* cancel any pending dialogs the plugin has */ + do_ask_cancel_by_handle(p->handle); + if (g_module_symbol(p->handle, "gaim_plugin_remove", (gpointer *)&gaim_plugin_remove)) gaim_plugin_remove(); plugin_remove_callbacks(p->handle);