diff libpurple/util.c @ 21621:b2aa68cdc8b9

I had used memcpy to copy the struct tm to where the caller wants it, but this assumes all callers provide their own allocated struct, which is not necessarily always the case. If callers want to keep the values of this struct tm across multiple calls to purple_str_to_time, they had better copy it themselves. (which is essentially the same as it was before when we were returning the pointer to the struct as returned by localtime(), which is also statically allocated)
author Stu Tomlinson <stu@nosnilmot.com>
date Fri, 23 Nov 2007 19:41:44 +0000
parents 31101e7d275f
children 8f82dc5e0b76 a9cb48039d3b
line wrap: on
line diff
--- a/libpurple/util.c	Thu Nov 22 19:34:50 2007 +0000
+++ b/libpurple/util.c	Fri Nov 23 19:41:44 2007 +0000
@@ -897,7 +897,7 @@
 
 	if (tm != NULL)
 	{
-		memcpy(tm, &t, sizeof(struct tm));
+		*tm = t;
 		tm->tm_isdst = -1;
 		mktime(tm);
 	}