diff src/protocols/oscar/ssi.c @ 4333:cc2f780c0505

[gaim-migrate @ 4597] I needed to make gc->login_time set before do_proto_menu was called, so I moved that line into account_online instead of serv_finish_login. serv_finish_login is called directly after account_online, and gc->login_time isn't used for anything anyway, so it shouldn't matter. I use gc->login_time to determine if a gc's protocol actions menu is ready to be drawn or not (should not be draw for accounts that are in the process of signing online). I made the "Show Buddies Awaiting Authorization" thing show something reasonable for when you aren't waiting for authorization from anyone. I swapped the ok and cancel buttons for the search for buddy by information and clear log file so they follow the HIG. I gave the right side of the log viewer a shadowed border. I Robot. I applied a patch from Ryan McCabe that doesn't really do anything for gaim (yet, anyway), but it allows clients using libfaim to call cleansnacs cleanly, which stops a potential build up of SNACs in memory when you don't send an IM for a long period of time. I applied another patch from Mr. McCabe that fixes a potential crash in ssi.c when your buddy list is a few lions short of a pride, if you know what I mean. I re-prettified an authorization dialog or two. The bold stuff and the non-bold stuff got backwardcised somehow. I added support for those messages from the ICQ server. Like the one that tells you not to give your password to anyone when you first signon. committer: Tailor Script <[e-mail]>

--- a/src/protocols/oscar/ssi.c	Sat Jan 18 01:09:59 2003 +0000
+++ b/src/protocols/oscar/ssi.c	Sat Jan 18 01:58:00 2003 +0000
@@ -637,7 +637,7 @@
  */
 faim_export int aim_ssi_cleanlist(aim_session_t *sess, aim_conn_t *conn)
 {
-	struct aim_ssi_item *cur;
+	struct aim_ssi_item *cur, *next;
 
 	/* If there are any buddies directly in the master group, put them in a real group */
 	/* This will kind of mess up if you hit the item limit, but this function isn't too critical */
@@ -646,17 +646,25 @@
 			aim_ssi_addbuddy(sess, conn, cur->name, "orphans", NULL, NULL, NULL, 0);
 
 	/* Now DESTROY any buddies that are directly in the master group */
-	for (cur=sess->ssi.local; cur; cur=cur->next)
+	cur = sess->ssi.local;
+	while (cur) {
+		next = cur->next;
 		if ((cur->type == AIM_SSI_TYPE_BUDDY) && (cur->gid == 0x0000))
 			aim_ssi_delbuddy(sess, conn, cur->name, NULL);
+		cur = next;
+	}
 
 	/* Check if there are empty groups */
-	for (cur=sess->ssi.local; cur; cur=cur->next)
+	cur = sess->ssi.local;
+	while (cur) {
+		next = cur->next;
 		if (cur->type == AIM_SSI_TYPE_GROUP) {
 			aim_tlv_t *tlv = aim_gettlv(cur->data, 0x00c8, 1);
 			if (!cur->data || !tlv || !tlv->length)
 				aim_ssi_itemlist_del(&sess->ssi.local, cur);
 		}
+		cur = next;
+	}
 
 	/* Check if the master group is empty */
 	if ((cur = aim_ssi_itemlist_find(sess->ssi.local, 0x0000, 0x0000)) && (!cur->data))