Mercurial > pidgin.yaz
diff src/gtkaccount.c @ 12600:e856f985a0b9
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Wed, 21 Dec 2005 18:36:19 +0000 |
parents | 8427ef2b4138 |
children | e63fb8e9f4ac |
line wrap: on
line diff
--- a/src/gtkaccount.c Wed Dec 21 13:37:18 2005 +0000 +++ b/src/gtkaccount.c Wed Dec 21 18:36:19 2005 +0000 @@ -1947,7 +1947,7 @@ GtkTreePath *source_row; GtkTreeIter iter; GaimAccount *account = NULL; - GValue val = {0}; + GValue val; ref = g_object_get_data(G_OBJECT(ctx), "gtk-tree-view-source-row"); source_row = gtk_tree_row_reference_get_path(ref); @@ -1957,6 +1957,7 @@ gtk_tree_model_get_iter(GTK_TREE_MODEL(dialog->model), &iter, source_row); + val.g_type = 0; gtk_tree_model_get_value(GTK_TREE_MODEL(dialog->model), &iter, COLUMN_DATA, &val); @@ -2025,9 +2026,10 @@ GtkTreeIter iter; GaimAccount *account; - GValue val = {0}; + GValue val; gtk_tree_model_get_iter(GTK_TREE_MODEL(dialog->model), &iter, path); + val.g_type = 0; gtk_tree_model_get_value(GTK_TREE_MODEL(dialog->model), &iter, COLUMN_DATA, &val);