Mercurial > pidgin.yaz
view src/debug.c @ 12233:02833a0ae716
[gaim-migrate @ 14535]
SF Patch #1367116 from Michael Carlson
"In profiling gaim, I noticed that on simply starting
CVS gaim, xmlnode_insert_child is using up by far the
most CPU time. After some testing, I realized the
reason why: xmlnode_insert_child is called some 18,000
times on startup, and it is inserting the child at the
end of the list each time, simply by traversing through
the entire linked list. Sometimes this list can have as
many as 800 elements.
This patch adds a variable to the _xmlnode struct,
lastchild, which simply keeps track of the last node in
the list of children. This is then used by
xmlnode_insert_child to insert at the end of the list,
instead of traversing through the whole list each time.
The two relevant functions in xmlnode.c that need to be
updated to keep track of this function appropriately
have been updated.
Running 3 times with and without the change, the
results from oprofile say it all. Here are the measured
number of clock cycles / % of total clock cycles /
function used to simply start and close gaim before the
change:
204 60.7143 xmlnode_insert_child
210 61.4035 xmlnode_insert_child
230 61.8280 xmlnode_insert_child
And after (note that one time no clock cycles were
caught at all)
3 2.5862 xmlnode_insert_child
3 2.5641 xmlnode_insert_child
This affects other areas of the program than just
starting up, but this seems to be the most noticeable
place."
Speed is good. As I was verifying this patch, I added some g_return_val_if_fail() checks.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 27 Nov 2005 03:42:39 +0000 |
parents | 921f64947cad |
children | e1e5462b7d81 |
line wrap: on
line source
/** * @file debug.c Debug API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "debug.h" #include "internal.h" #include "prefs.h" static GaimDebugUiOps *debug_ui_ops = NULL; /* * This determines whether debug info should be written to the * console or not. * * It doesn't make sense to make this a normal Gaim preference * because it's a command line option. This will always be FALSE, * unless the user explicitly started Gaim with the -d flag. * It doesn't matter what this value was the last time Gaim was * started, so it doesn't make sense to save it in prefs. */ static gboolean debug_enabled = FALSE; static void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args) { GaimDebugUiOps *ops; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); if (debug_enabled) { gchar *arg_s, *ts_s; arg_s = g_strdup_vprintf(format, args); if ((category != NULL) && (gaim_prefs_exists("/core/debug/timestamps")) && (gaim_prefs_get_bool("/core/debug/timestamps"))) { gchar mdate[64]; time_t mtime = time(NULL); strftime(mdate, sizeof(mdate), "%H:%M:%S", localtime(&mtime)); ts_s = g_strdup_printf("(%s) ", mdate); } else { ts_s = g_strdup(""); } if (category == NULL) g_print("%s%s", ts_s, arg_s); else g_print("%s%s: %s", ts_s, category, arg_s); g_free(arg_s); g_free(ts_s); } ops = gaim_debug_get_ui_ops(); if (ops != NULL && ops->print != NULL) ops->print(level, category, format, args); } void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...) { va_list args; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(level, category, format, args); va_end(args); } void gaim_debug_misc(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_MISC, category, format, args); va_end(args); } void gaim_debug_info(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_INFO, category, format, args); va_end(args); } void gaim_debug_warning(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_WARNING, category, format, args); va_end(args); } void gaim_debug_error(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_ERROR, category, format, args); va_end(args); } void gaim_debug_fatal(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_FATAL, category, format, args); va_end(args); } void gaim_debug_set_enabled(gboolean enabled) { debug_enabled = enabled; } gboolean gaim_debug_is_enabled() { return debug_enabled; } void gaim_debug_set_ui_ops(GaimDebugUiOps *ops) { debug_ui_ops = ops; } GaimDebugUiOps * gaim_debug_get_ui_ops(void) { return debug_ui_ops; } void gaim_debug_init(void) { gaim_prefs_add_none("/core/debug"); /* * This pref is currently used by both the console * output and the debug window output. */ gaim_prefs_add_bool("/core/debug/timestamps", FALSE); }