view src/mediastreamer/msqdispatcher.h @ 12233:02833a0ae716

[gaim-migrate @ 14535] SF Patch #1367116 from Michael Carlson "In profiling gaim, I noticed that on simply starting CVS gaim, xmlnode_insert_child is using up by far the most CPU time. After some testing, I realized the reason why: xmlnode_insert_child is called some 18,000 times on startup, and it is inserting the child at the end of the list each time, simply by traversing through the entire linked list. Sometimes this list can have as many as 800 elements. This patch adds a variable to the _xmlnode struct, lastchild, which simply keeps track of the last node in the list of children. This is then used by xmlnode_insert_child to insert at the end of the list, instead of traversing through the whole list each time. The two relevant functions in xmlnode.c that need to be updated to keep track of this function appropriately have been updated. Running 3 times with and without the change, the results from oprofile say it all. Here are the measured number of clock cycles / % of total clock cycles / function used to simply start and close gaim before the change: 204 60.7143 xmlnode_insert_child 210 61.4035 xmlnode_insert_child 230 61.8280 xmlnode_insert_child And after (note that one time no clock cycles were caught at all) 3 2.5862 xmlnode_insert_child 3 2.5641 xmlnode_insert_child This affects other areas of the program than just starting up, but this seems to be the most noticeable place." Speed is good. As I was verifying this patch, I added some g_return_val_if_fail() checks. committer: Tailor Script <[e-mail]>

/*
  The mediastreamer library aims at providing modular media processing and I/O
	for linphone, but also for any telephony application.
  Copyright (C) 2001  Simon MORLAT [e-mail]
  										
  This library is free software; you can redistribute it and/or
  modify it under the terms of the GNU Lesser General Public
  License as published by the Free Software Foundation; either
  version 2.1 of the License, or (at your option) any later version.

  This library is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  Lesser General Public License for more details.

  You should have received a dispatcher of the GNU Lesser General Public
  License along with this library; if not, write to the Free Software
  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
*/


#ifndef MSQDISPATCHER_H
#define MSQDISPATCHER_H

#include "msfilter.h"


/*this is the class that implements a qdispatcher filter*/

#define MS_QDISPATCHER_MAX_INPUTS  1
#define MS_QDISPATCHER_MAX_OUTPUTS 5 

typedef struct _MSQdispatcher
{
    /* the MSQdispatcher derivates from MSFilter, so the MSFilter object MUST be the first of the MSQdispatcher object
       in order to the object mechanism to work*/
    MSFilter filter;
	MSQueue *q_inputs[MS_QDISPATCHER_MAX_INPUTS];
	MSQueue *q_outputs[MS_QDISPATCHER_MAX_OUTPUTS];
} MSQdispatcher;

typedef struct _MSQdispatcherClass
{
	/* the MSQdispatcher derivates from MSFilter, so the MSFilter class MUST be the first of the MSQdispatcher class
       in order to the class mechanism to work*/
	MSFilterClass parent_class;
} MSQdispatcherClass;

/* PUBLIC */
#define MS_QDISPATCHER(filter) ((MSQdispatcher*)(filter))
#define MS_QDISPATCHER_CLASS(klass) ((MSQdispatcherClass*)(klass))
MSFilter * ms_qdispatcher_new(void);

/* FOR INTERNAL USE*/
void ms_qdispatcher_init(MSQdispatcher *r);
void ms_qdispatcher_class_init(MSQdispatcherClass *klass);
void ms_qdispatcher_destroy( MSQdispatcher *obj);
void ms_qdispatcher_process(MSQdispatcher *r);

#endif