view PROGRAMMING_NOTES @ 5531:10920646988f

[gaim-migrate @ 5931] Ambrose LI (acli) writes: " This is w.r.t. the 0.64cvs as of around 20:25 EDT. When gaim starts up, it displays the signon window, and then immeidately segfaults. The problem is that tobase64() in util.c uses a size_t (which could very likely be unsigned) as a second parameter, but proxy.c calls it with a -1. " at my questioning the specific change he made: "Actually the initialization is not the matter (just something I did while debugging and did not remove, since it makes sense in any case), it's the other change that matters. In util.h, the javadoc-like comments states that passing len = -1 means that tobase64() should calculated len = strlen(buf). However, since size_t is (or can be) unsigned, the "if (len < 0)" check never succeeds, so passing -1 actually results in a very large integer being passed. So the "if (len < 0)" check actually need to be changed so that the passed "-1" will actually get recognized." so since most of us aren't segfaulting on start, i'm guessing this is a platform/os specific problem, but that the change shouldn't affect the rest of us anyway. committer: Tailor Script <[e-mail]>

Notes on keeping GAIM OS independant
------------------------------------

General
-------
- Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths

- Use g_getenv, g_snprintf, g_vsnprintf

- Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME")

- Make sure when including win32dep.h that it is the last header to
  be included.

- Open binary files when reading or writing with 'b' mode.

  e.g: fopen("somefile", "wb");

  Not doing so will open files in windows using defaut translation mode. 
  i.e. newline -> <CR><LF>

Paths
-----

- DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions.
  Doing the following will therefore break the windows build:

  printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png");

  it should be:

  printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png");

- When writing out paths to .gaimrc, use wgaim_escape_dirsep. This is necessary
  because the Windows dir separator '\' is being used to escape characters, when
  paths are read in from the .gaimrc file.

PLUGINS & PROTOS
----------------

- G_MODULE_EXPORT all functions which are to be accessed from outside the
  scope of its "dll" or "so". (E.G. gaim_plugin_init)

- G_MODULE_IMPORT all global variables which are located outside your
  dynamic library. (E.G. connections)

  (Not doing this will cause "Memory Access Violations" in Win32)