Mercurial > pidgin.yaz
view gaim.desktop @ 5531:10920646988f
[gaim-migrate @ 5931]
Ambrose LI (acli) writes:
" This is w.r.t. the 0.64cvs as of around 20:25 EDT.
When gaim starts up, it displays the signon window, and
then immeidately segfaults. The problem is that
tobase64() in util.c uses a size_t (which could very
likely be unsigned) as a second parameter, but proxy.c
calls it with a -1. "
at my questioning the specific change he made:
"Actually the initialization is not the matter (just
something I did while debugging and did not remove, since it
makes sense in any case), it's the other change that matters.
In util.h, the javadoc-like comments states that passing len
= -1 means that tobase64() should calculated len =
strlen(buf). However, since size_t is (or can be) unsigned,
the "if (len < 0)" check never succeeds, so passing
-1
actually results in a very large integer being passed.
So the "if (len < 0)" check actually need to be
changed so
that the passed "-1" will actually get recognized."
so since most of us aren't segfaulting on start, i'm guessing this is a
platform/os specific problem, but that the change shouldn't affect the
rest of us anyway.
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Mon, 26 May 2003 12:45:05 +0000 |
parents | 788f78343113 |
children | 282887c9e3dc |
line wrap: on
line source
[Desktop Entry] Encoding=UTF-8 Name=Gaim Comment=Multi-protocol Instant Messaging Client Comment[es]=Cliente de mensajería instantánea multiprotocolo Comment[fr]=Client de messagerie instantanée multiprotocole Comment[de]=Multi-Protokoll Instant Messenger Client Comment[ko]=멀티 프로토콜 인스턴트 메시징 클라이언트 Exec=gaim Icon=gaim.png Terminal=false Type=Application Categories=Application;Network;