Mercurial > pidgin.yaz
view src/privacy.h @ 5531:10920646988f
[gaim-migrate @ 5931]
Ambrose LI (acli) writes:
" This is w.r.t. the 0.64cvs as of around 20:25 EDT.
When gaim starts up, it displays the signon window, and
then immeidately segfaults. The problem is that
tobase64() in util.c uses a size_t (which could very
likely be unsigned) as a second parameter, but proxy.c
calls it with a -1. "
at my questioning the specific change he made:
"Actually the initialization is not the matter (just
something I did while debugging and did not remove, since it
makes sense in any case), it's the other change that matters.
In util.h, the javadoc-like comments states that passing len
= -1 means that tobase64() should calculated len =
strlen(buf). However, since size_t is (or can be) unsigned,
the "if (len < 0)" check never succeeds, so passing
-1
actually results in a very large integer being passed.
So the "if (len < 0)" check actually need to be
changed so
that the passed "-1" will actually get recognized."
so since most of us aren't segfaulting on start, i'm guessing this is a
platform/os specific problem, but that the change shouldn't affect the
rest of us anyway.
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Mon, 26 May 2003 12:45:05 +0000 |
parents | 283fb289c510 |
children | 9eb5b13fd412 |
line wrap: on
line source
/* * gaim * * Copyright (C) 2003, Christian Hammond <chipx86@gnupdate.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "gaim.h" gboolean gaim_privacy_permit_add(struct gaim_account *account, const char *name); gboolean gaim_privacy_deny_add(struct gaim_account *account, const char *name); gboolean gaim_privacy_deny_remove(struct gaim_account *account, const char *name); gboolean gaim_privacy_permit_remove(struct gaim_account *account, const char *name);