view plugins/crazychat/camdata.h @ 11719:109ee3bfeac5

[gaim-migrate @ 14010] SF Patch #1333770 from corfe83 "Many times in gaim we use the function g_slist_remove(list,node->data) to remove an element from a GSList. If we already have the pointer to the node we want to delete, it is faster to send it the pointer to the node to delete rather than the data of the node (we can do this by calling g_slist_delete_link(list,node)). This change was made while looking at glib's documentation and the code in glib's gslist.c. This is because as the remove/delete function traverses each node in the list, it doesn't need to spend an extra memory access to retrieve the data for each element in the node it is traversing and then compare, it can simply compare the pointer. In my tests outside of gaim, this makes a big difference if the node you are deleting is at a high index in the list. However, even if you're deleting the first node, it about breaks even. So, I've found each case in gaim where we are calling g_slist_remove, and we already have the pointer to the appropriate node to delete (this is often the case when we're doing a for or while loop on a GSList). I've then replaced it with the appropriate call to g_slist_delete_link. I, however, didn't do this in situations where we are explicitly removing the first element in the list, because in those situations it is an unnecessary change. There should be no difference in behavior, but just in case I've tried running it with valgrind, which reports the same number of memory leaks after my patch as before my patch. Of course, I can't guarantee that my normal behavior on gaim is hitting all the functions I've changed, but in general testing it Works For Me (tm)." As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying. committer: Tailor Script <[e-mail]>

/*
 *  camdata.h
 *  basecame
 *
 *  Created by CS194 on Mon Apr 26 2004.
 *  Copyright (c) 2004 __MyCompanyName__. All rights reserved.
 *
 */
 
#pragma once

#ifdef __APPLE_CC__
//	#include <Carbon/Carbon.h>
	#include <QuickTime/QuickTime.h>
#else
//	#include <Carbon.h>
	#include <QuickTime.h>
#endif

typedef struct 
{
	GWorldPtr 				gw;
	GWorldPtr 				overlay;
	GWorldPtr 				histoWorld;
	
	Rect 					bounds;
	WindowPtr				window;
	ImageSequence 			drawSeq;
	UInt32					redMin, redMax;
	UInt32					greenMin, greenMax;
	UInt32					blueMin, blueMax;

	long					selectedIndex;
	OSType					effect;
	TimeBase				effectTimeBase;
	QTAtomContainer			effectParams;
	ImageDescriptionHandle 	effectDesc, effectDesc2;
}	mungDataRecord;
typedef mungDataRecord *mungDataPtr;

OSErr DisposeMungData(void);
OSErr InitializeMungData(Rect bounds);
void SetCurrentClamp(short index);

//void BlitOneMungData(mungDataRecord *theMungData);

//void AdjustColorClampEndpoints(short hMouseCoord);
//void IncrementCurrentClamp();
//void DecrementCurrentClamp();
void SetMungDataColorDefaults();
CGrafPtr GetMungDataWindowPort();

GWorldPtr GetMungDataOffscreen(void);
//OSType GetMungDataEffectType();

//long GetCurrentClamp();
//void SetCurrentClamp(short index);

void GetMungDataBoundsRect(Rect *movieRect);
//CGrafPtr GetMungDataWindowPort();

void SetMungDataDrawSeq(ImageSequence theDrawSeq);
//ImageSequence GetMungDataDrawSeq();