Mercurial > pidgin.yaz
view plugins/history.c @ 11719:109ee3bfeac5
[gaim-migrate @ 14010]
SF Patch #1333770 from corfe83
"Many times in gaim we use the function
g_slist_remove(list,node->data) to remove an element
from a GSList. If we already have the pointer to the
node we want to delete, it is faster to send it the
pointer to the node to delete rather than the data of
the node (we can do this by calling
g_slist_delete_link(list,node)). This change was made
while looking at glib's documentation and the code in
glib's gslist.c.
This is because as the remove/delete function traverses
each node in the list, it doesn't need to spend an
extra memory access to retrieve the data for each
element in the node it is traversing and then compare,
it can simply compare the pointer. In my tests outside
of gaim, this makes a big difference if the node you
are deleting is at a high index in the list. However,
even if you're deleting the first node, it about breaks
even.
So, I've found each case in gaim where we are calling
g_slist_remove, and we already have the pointer to the
appropriate node to delete (this is often the case when
we're doing a for or while loop on a GSList). I've then
replaced it with the appropriate call to
g_slist_delete_link. I, however, didn't do this in
situations where we are explicitly removing the first
element in the list, because in those situations it is
an unnecessary change.
There should be no difference in behavior, but just in
case I've tried running it with valgrind, which reports
the same number of memory leaks after my patch as
before my patch. Of course, I can't guarantee that my
normal behavior on gaim is hitting all the functions
I've changed, but in general testing it Works For Me (tm)."
As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 22 Oct 2005 20:48:18 +0000 |
parents | f36471a3c258 |
children | fa17fc619f17 |
line wrap: on
line source
/* Puts last 4k of log in new conversations a la Everybuddy (and then * stolen by Trillian "Pro") */ #include "internal.h" #include "gtkgaim.h" #include "conversation.h" #include "debug.h" #include "log.h" #include "notify.h" #include "prefs.h" #include "signals.h" #include "util.h" #include "version.h" #include "gtkconv.h" #include "gtkimhtml.h" #include "gtkplugin.h" #define HISTORY_PLUGIN_ID "gtk-history" #define HISTORY_SIZE (4 * 1024) static gboolean _scroll_imhtml_to_end(gpointer data) { GtkIMHtml *imhtml = data; gtk_imhtml_scroll_to_end(GTK_IMHTML(imhtml)); g_object_unref(G_OBJECT(imhtml)); return FALSE; } static void historize(GaimConversation *c) { GaimAccount *account = gaim_conversation_get_account(c); const char *name = gaim_conversation_get_name(c); GaimConversationType convtype; GList *logs = NULL; const char *alias = name; guint flags; char *history; GaimGtkConversation *gtkconv; GtkIMHtmlOptions options = GTK_IMHTML_NO_COLOURS; time_t tm; char day[64]; char *header; convtype = gaim_conversation_get_type(c); gtkconv = GAIM_GTK_CONVERSATION(c); if (convtype == GAIM_CONV_TYPE_IM && g_list_length(gtkconv->convs) < 2) { GSList *buddies; GSList *cur; /* If we're not logging, don't show anything. * Otherwise, we might show a very old log. */ if (!gaim_prefs_get_bool("/core/logging/log_ims")) return; /* Find buddies for this conversation. */ buddies = gaim_find_buddies(account, name); /* If we found at least one buddy, save the first buddy's alias. */ if (buddies != NULL) alias = gaim_buddy_get_contact_alias((GaimBuddy *)buddies->data); for (cur = buddies; cur != NULL; cur = cur->next) { GaimBlistNode *node = cur->data; if ((node != NULL) && ((node->prev != NULL) || (node->next != NULL))) { GaimBlistNode *node2; alias = gaim_buddy_get_contact_alias((GaimBuddy *)node); /* We've found a buddy that matches this conversation. It's part of a * GaimContact with more than one GaimBuddy. Loop through the GaimBuddies * in the contact and get all the logs. */ for (node2 = node->parent->child ; node2 != NULL ; node2 = node2->next) { logs = g_list_concat( gaim_log_get_logs(GAIM_LOG_IM, gaim_buddy_get_name((GaimBuddy *)node2), gaim_buddy_get_account((GaimBuddy *)node2)), logs); } break; } } g_slist_free(buddies); if (logs == NULL) logs = gaim_log_get_logs(GAIM_LOG_IM, name, account); else logs = g_list_sort(logs, gaim_log_compare); } else if (convtype == GAIM_CONV_TYPE_CHAT) { /* If we're not logging, don't show anything. * Otherwise, we might show a very old log. */ if (!gaim_prefs_get_bool("/core/logging/log_chats")) return; logs = gaim_log_get_logs(GAIM_LOG_CHAT, name, account); } if (logs == NULL) return; history = gaim_log_read((GaimLog*)logs->data, &flags); gtkconv = GAIM_GTK_CONVERSATION(c); if (flags & GAIM_LOG_READ_NO_NEWLINE) options |= GTK_IMHTML_NO_NEWLINE; tm = ((GaimLog *)logs->data)->time; gaim_strftime(day, sizeof(day), "%c", localtime(&tm)); header = g_strdup_printf("<b>Conversation with %s on %s:</b><br>", alias, day); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), header, options); g_free(header); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), history, options); g_free(history); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), "<hr>", options); g_object_ref(G_OBJECT(gtkconv->imhtml)); g_idle_add(_scroll_imhtml_to_end, gtkconv->imhtml); g_list_foreach(logs, (GFunc)gaim_log_free, NULL); g_list_free(logs); } static void history_prefs_check(GaimPlugin *plugin) { if (!gaim_prefs_get_bool("/core/logging/log_ims") && !gaim_prefs_get_bool("/core/logging/log_chats")) { gaim_notify_warning(plugin, NULL, _("History Plugin Requires Logging"), _("Logging can be enabled from Tools -> Preferences -> Logging.\n\n" "Enabling logs for instant messages and/or chats will activate " "history for the same conversation type(s).")); } } static void history_prefs_cb(const char *name, GaimPrefType type, gpointer val, gpointer data) { history_prefs_check((GaimPlugin *)data); } static gboolean plugin_load(GaimPlugin *plugin) { gaim_signal_connect(gaim_conversations_get_handle(), "conversation-created", plugin, GAIM_CALLBACK(historize), NULL); gaim_prefs_connect_callback(plugin, "/core/logging/log_ims", history_prefs_cb, plugin); gaim_prefs_connect_callback(plugin, "/core/logging/log_chats", history_prefs_cb, plugin); history_prefs_check(plugin); return TRUE; } static GaimPluginInfo info = { GAIM_PLUGIN_MAGIC, GAIM_MAJOR_VERSION, GAIM_MINOR_VERSION, GAIM_PLUGIN_STANDARD, GAIM_GTK_PLUGIN_TYPE, 0, NULL, GAIM_PRIORITY_DEFAULT, HISTORY_PLUGIN_ID, N_("History"), VERSION, N_("Shows recently logged conversations in new conversations."), N_("When a new conversation is opened this plugin will insert " "the last conversation into the current conversation.\n\n" "The history plugin requires logging be enabled. Logging can " "be enabled from Tools -> Preferences -> Logging. Enabling logs " "for instant messages and/or chats will activate history for " "the same conversation type(s)." ), "Sean Egan <bj91704@binghamton.edu>", GAIM_WEBSITE, plugin_load, NULL, NULL, NULL, NULL, NULL, NULL }; static void init_plugin(GaimPlugin *plugin) { } GAIM_INIT_PLUGIN(history, init_plugin, info)