view src/gtkprefs.h @ 11719:109ee3bfeac5

[gaim-migrate @ 14010] SF Patch #1333770 from corfe83 "Many times in gaim we use the function g_slist_remove(list,node->data) to remove an element from a GSList. If we already have the pointer to the node we want to delete, it is faster to send it the pointer to the node to delete rather than the data of the node (we can do this by calling g_slist_delete_link(list,node)). This change was made while looking at glib's documentation and the code in glib's gslist.c. This is because as the remove/delete function traverses each node in the list, it doesn't need to spend an extra memory access to retrieve the data for each element in the node it is traversing and then compare, it can simply compare the pointer. In my tests outside of gaim, this makes a big difference if the node you are deleting is at a high index in the list. However, even if you're deleting the first node, it about breaks even. So, I've found each case in gaim where we are calling g_slist_remove, and we already have the pointer to the appropriate node to delete (this is often the case when we're doing a for or while loop on a GSList). I've then replaced it with the appropriate call to g_slist_delete_link. I, however, didn't do this in situations where we are explicitly removing the first element in the list, because in those situations it is an unnecessary change. There should be no difference in behavior, but just in case I've tried running it with valgrind, which reports the same number of memory leaks after my patch as before my patch. Of course, I can't guarantee that my normal behavior on gaim is hitting all the functions I've changed, but in general testing it Works For Me (tm)." As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying. committer: Tailor Script <[e-mail]>

/**
 * @file gtkprefs.h GTK+ Preferences
 * @ingroup gtkui
 *
 * gaim
 *
 * Gaim is the legal property of its developers, whose names are too numerous
 * to list here.  Please refer to the COPYRIGHT file distributed with this
 * source distribution.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 *
 */
#ifndef _GAIM_GTKPREFS_H_
#define _GAIM_GTKPREFS_H_

#include "prefs.h"

/**
 * Initializes all UI-specific preferences.
 */
void gaim_gtk_prefs_init(void);

/**
 * Shows the preferences dialog.
 */
void gaim_gtk_prefs_show(void);

/**
 * Add a new checkbox for a boolean preference
 *
 * @param title The text to be displayed as the checkbox label
 * @param key   The key of the gaim bool pref that will be represented by the checkbox
 * @param page  The page to which the new checkbox will be added
 */
GtkWidget *gaim_gtk_prefs_checkbox(const char *title, const char *key,
		GtkWidget *page);

/**
 * Add a new spin button representing an int preference
 *
 * @param page  The page to which the spin button will be added
 * @param title The text to be displayed as the spin button label
 * @param key   The key of the int pref that will be represented by the spin button
 * @param min   The minimum value of the spin button
 * @param max   The maximum value of the spin button
 * @param sg    If not NULL, the size group to which the spin button will be added
 * @return      An hbox containing both the label and the spinner.  Can be
 *              used to set the widgets to sensitive or insensitive based on the 
 *              value of a checkbox.
 */
GtkWidget *gaim_gtk_prefs_labeled_spin_button(GtkWidget *page,
		const gchar *title, const char *key, int min, int max, GtkSizeGroup *sg);

/**
 * Add a new entry representing a string preference
 *
 * @param page  The page to which the entry will be added
 * @param title The text to be displayed as the entry label
 * @param key   The key of the string pref that will be represented by the entry
 * @param sg    If not NULL, the size group to which the entry will be added
 *
 * @return      An hbox containing both the label and the entry.  Can be used to set
 *               the widgets to sensitive or insensitive based on the value of a
 *               checkbox.
 */
GtkWidget *gaim_gtk_prefs_labeled_entry(GtkWidget *page, const gchar *title,
										const char *key, GtkSizeGroup *sg);

/**
 * Add a new dropdown representing a preference of the specified type
 *
 * @param page  The page to which the dropdown will be added
 * @param title The text to be displayed as the dropdown label
 * @param type  The type of preference to be stored in the generated dropdown
 * @param key   The key of the pref that will be represented by the dropdown
 * @param ...   The choices to be added to the dropdown, choices should be
 *              paired as label/value
 */
GtkWidget *gaim_gtk_prefs_dropdown(GtkWidget *page, const gchar *title,
		GaimPrefType type, const char *key, ...);

/**
 * Add a new dropdown representing a preference of the specified type
 *
 * @param page      The page to which the dropdown will be added
 * @param title     The text to be displayed as the dropdown label
 * @param type      The type of preference to be stored in the dropdown
 * @param key       The key of the pref that will be represented by the dropdown
 * @param menuitems The choices to be added to the dropdown, choices should
 *                  be paired as label/value
 */
GtkWidget *gaim_gtk_prefs_dropdown_from_list(GtkWidget *page,
		const gchar * title, GaimPrefType type, const char *key,
		GList *menuitems);

/**
 * Rename legacy prefs and delete some that no longer exist.
 */
void gaim_gtk_prefs_update_old();

#endif /* _GAIM_GTKPREFS_H_ */