Mercurial > pidgin.yaz
view src/mime.h @ 11719:109ee3bfeac5
[gaim-migrate @ 14010]
SF Patch #1333770 from corfe83
"Many times in gaim we use the function
g_slist_remove(list,node->data) to remove an element
from a GSList. If we already have the pointer to the
node we want to delete, it is faster to send it the
pointer to the node to delete rather than the data of
the node (we can do this by calling
g_slist_delete_link(list,node)). This change was made
while looking at glib's documentation and the code in
glib's gslist.c.
This is because as the remove/delete function traverses
each node in the list, it doesn't need to spend an
extra memory access to retrieve the data for each
element in the node it is traversing and then compare,
it can simply compare the pointer. In my tests outside
of gaim, this makes a big difference if the node you
are deleting is at a high index in the list. However,
even if you're deleting the first node, it about breaks
even.
So, I've found each case in gaim where we are calling
g_slist_remove, and we already have the pointer to the
appropriate node to delete (this is often the case when
we're doing a for or while loop on a GSList). I've then
replaced it with the appropriate call to
g_slist_delete_link. I, however, didn't do this in
situations where we are explicitly removing the first
element in the list, because in those situations it is
an unnecessary change.
There should be no difference in behavior, but just in
case I've tried running it with valgrind, which reports
the same number of memory leaks after my patch as
before my patch. Of course, I can't guarantee that my
normal behavior on gaim is hitting all the functions
I've changed, but in general testing it Works For Me (tm)."
As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 22 Oct 2005 20:48:18 +0000 |
parents | 8dca96cbcd64 |
children | fc464a0abccc |
line wrap: on
line source
/* Gaim Gaim is the legal property of its developers, whose names are too numerous to list here. Please refer to the COPYRIGHT file distributed with this source distribution This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef _GAIM_MIME_H #define _GAIM_MIME_H #include <glib.h> #include <glib/glist.h> /** @file mime.h @ingroup core Rudimentary parsing of multi-part MIME messages into more accessible structures. */ /** @typedef GaimMimeDocument A MIME document */ typedef struct _GaimMimeDocument GaimMimeDocument; /** @typedef GaimMimePart A part of a multipart MIME document */ typedef struct _GaimMimePart GaimMimePart; /** Allocate an empty MIME document */ GaimMimeDocument *gaim_mime_document_new(); /** Frees memory used in a MIME document and all of its parts and fields @param doc the MIME document to free */ void gaim_mime_document_free(GaimMimeDocument *doc); /** Parse a MIME document from a NUL-terminated string @param buf the NULL-terminated string containing the MIME-encoded data @returns MIME document */ GaimMimeDocument *gaim_mime_document_parse(const char *buf); /** Parse a MIME document from a string @param buf the string containing the MIME-encoded data @param len length of buf @returns MIME document */ GaimMimeDocument *gaim_mime_document_parsen(const char *buf, gsize len); /** Write (append) a MIME document onto a GString */ void gaim_mime_document_write(GaimMimeDocument *doc, GString *str); /** The list of fields in the header of a document @param doc the MIME document @returns list of strings indicating the fields (but not the values of the fields) in the header of doc */ const GList *gaim_mime_document_get_fields(GaimMimeDocument *doc); /** Get the value of a specific field in the header of a document @param doc the MIME document @param field case-insensitive field name @returns value associated with the indicated header field, or NULL if the field doesn't exist */ const char *gaim_mime_document_get_field(GaimMimeDocument *doc, const char *field); /** Set or replace the value of a specific field in the header of a document @param doc the MIME document @param field case-insensitive field name @param value value to associate with the indicated header field, of NULL to remove the field */ void gaim_mime_document_set_field(GaimMimeDocument *doc, const char *field, const char *value); /** The list of parts in a multipart document @param doc the MIME document @returns list of GaimMimePart contained within doc */ const GList *gaim_mime_document_get_parts(GaimMimeDocument *doc); /** Create and insert a new part into a MIME document @param doc the new part's parent MIME document */ GaimMimePart *gaim_mime_part_new(GaimMimeDocument *doc); /** The list of fields in the header of a document part @param part the MIME document part @returns list of strings indicating the fields (but not the values of the fields) in the header of part */ const GList *gaim_mime_part_get_fields(GaimMimePart *part); /** Get the value of a specific field in the header of a document part @param part the MIME document part @param field case-insensitive name of the header field @returns value of the specified header field, or NULL if the field doesn't exist */ const char *gaim_mime_part_get_field(GaimMimePart *part, const char *field); /** Get the decoded value of a specific field in the header of a document part */ char *gaim_mime_part_get_field_decoded(GaimMimePart *part, const char *field); /** Set or replace the value of a specific field in the header of a document @param part the part of the MIME document @param field case-insensitive field name @param value value to associate with the indicated header field, of NULL to remove the field */ void gaim_mime_part_set_field(GaimMimePart *part, const char *field, const char *value); /** Get the (possibly encoded) data portion of a MIME document part @param part the MIME document part @returns NULL-terminated data found in the document part */ const char *gaim_mime_part_get_data(GaimMimePart *part); /** Get the data portion of a MIME document part, after attempting to decode it according to the content-transfer-encoding field. If the specified encoding method is not supported, this function will return NULL. @param part the MIME documemt part @param data Buffer for the data @param len The length of the buffer */ void gaim_mime_part_get_data_decoded(GaimMimePart *part, guchar **data, gsize *len); /** Get the length of the data portion of a MIME document part @param part the MIME document part @returns length of the data in the document part */ gsize gaim_mime_part_get_length(GaimMimePart *part); void gaim_mime_part_set_data(GaimMimePart *part, const char *data); #endif