Mercurial > pidgin.yaz
view src/sslconn.h @ 11719:109ee3bfeac5
[gaim-migrate @ 14010]
SF Patch #1333770 from corfe83
"Many times in gaim we use the function
g_slist_remove(list,node->data) to remove an element
from a GSList. If we already have the pointer to the
node we want to delete, it is faster to send it the
pointer to the node to delete rather than the data of
the node (we can do this by calling
g_slist_delete_link(list,node)). This change was made
while looking at glib's documentation and the code in
glib's gslist.c.
This is because as the remove/delete function traverses
each node in the list, it doesn't need to spend an
extra memory access to retrieve the data for each
element in the node it is traversing and then compare,
it can simply compare the pointer. In my tests outside
of gaim, this makes a big difference if the node you
are deleting is at a high index in the list. However,
even if you're deleting the first node, it about breaks
even.
So, I've found each case in gaim where we are calling
g_slist_remove, and we already have the pointer to the
appropriate node to delete (this is often the case when
we're doing a for or while loop on a GSList). I've then
replaced it with the appropriate call to
g_slist_delete_link. I, however, didn't do this in
situations where we are explicitly removing the first
element in the list, because in those situations it is
an unnecessary change.
There should be no difference in behavior, but just in
case I've tried running it with valgrind, which reports
the same number of memory leaks after my patch as
before my patch. Of course, I can't guarantee that my
normal behavior on gaim is hitting all the functions
I've changed, but in general testing it Works For Me (tm)."
As with the last patch, this one may not have a practical performance impact (or maybe it does, I have no idea), but it's not worse for any case. Given two ways of doing things where one is always at least as fast and may be faster under some cases, I like to prefer that faster way. This doesn't make the code any uglier, so I'm applying.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 22 Oct 2005 20:48:18 +0000 |
parents | db62420a53a2 |
children | c8ebbc0110f4 |
line wrap: on
line source
/** * @file sslconn.h SSL API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GAIM_SSLCONN_H_ #define _GAIM_SSLCONN_H_ #include "proxy.h" #define GAIM_SSL_DEFAULT_PORT 443 typedef enum { GAIM_SSL_HANDSHAKE_FAILED = 1, GAIM_SSL_CONNECT_FAILED = 2 } GaimSslErrorType; typedef struct _GaimSslConnection GaimSslConnection; typedef void (*GaimSslInputFunction)(gpointer, GaimSslConnection *, GaimInputCondition); typedef void (*GaimSslErrorFunction)(GaimSslConnection *, GaimSslErrorType, gpointer); struct _GaimSslConnection { char *host; int port; void *connect_cb_data; GaimSslInputFunction connect_cb; GaimSslErrorFunction error_cb; void *recv_cb_data; GaimSslInputFunction recv_cb; int fd; int inpa; void *private_data; }; /** * SSL implementation operations structure. * * Every SSL implementation must provide one of these and register it. */ typedef struct { gboolean (*init)(void); void (*uninit)(void); GaimInputFunction connect_cb; void (*close)(GaimSslConnection *gsc); size_t (*read)(GaimSslConnection *gsc, void *data, size_t len); size_t (*write)(GaimSslConnection *gsc, const void *data, size_t len); } GaimSslOps; #ifdef __cplusplus extern "C" { #endif /**************************************************************************/ /** @name SSL API */ /**************************************************************************/ /*@{*/ /** * Returns whether or not SSL is currently supported. * * @return TRUE if SSL is supported, or FALSE otherwise. */ gboolean gaim_ssl_is_supported(void); /** * Makes a SSL connection to the specified host and port. * * @param account The account making the connection. * @param host The destination host. * @param port The destination port. * @param func The SSL input handler function. * @param error_func The SSL error handler function. * @param data User-defined data. * * @return The SSL connection handle. */ GaimSslConnection *gaim_ssl_connect(GaimAccount *account, const char *host, int port, GaimSslInputFunction func, GaimSslErrorFunction error_func, void *data); /** * Makes a SSL connection using an already open file descriptor. * * @param account The account making the connection. * @param fd The file descriptor. * @param func The SSL input handler function. * @param error_func The SSL error handler function. * @param data User-defined data. * * @return The SSL connection handle. */ GaimSslConnection *gaim_ssl_connect_fd(GaimAccount *account, int fd, GaimSslInputFunction func, GaimSslErrorFunction error_func, void *data); /** * Adds an input watcher for the specified SSL connection. * * @param gsc The SSL connection handle. * @param func The callback function. * @param data User-defined data. */ void gaim_ssl_input_add(GaimSslConnection *gsc, GaimSslInputFunction func, void *data); /** * Closes a SSL connection. * * @param gsc The SSL connection to close. */ void gaim_ssl_close(GaimSslConnection *gsc); /** * Reads data from an SSL connection. * * @param gsc The SSL connection handle. * @param buffer The destination buffer. * @param len The maximum number of bytes to read. * * @return The number of bytes read. */ size_t gaim_ssl_read(GaimSslConnection *gsc, void *buffer, size_t len); /** * Writes data to an SSL connection. * * @param gsc The SSL connection handle. * @param buffer The buffer to write. * @param len The length of the data to write. * * @return The number of bytes written. */ size_t gaim_ssl_write(GaimSslConnection *gsc, const void *buffer, size_t len); /*@}*/ /**************************************************************************/ /** @name Subsystem API */ /**************************************************************************/ /*@{*/ /** * Sets the current SSL operations structure. * * @param ops The SSL operations structure to assign. */ void gaim_ssl_set_ops(GaimSslOps *ops); /** * Returns the current SSL operations structure. * * @return The SSL operations structure. */ GaimSslOps *gaim_ssl_get_ops(void); /** * Initializes the SSL subsystem. */ void gaim_ssl_init(void); /** * Uninitializes the SSL subsystem. */ void gaim_ssl_uninit(void); /*@}*/ #ifdef __cplusplus } #endif #endif /* _GAIM_SSLCONN_H_ */