view COPYRIGHT @ 8672:142108e89399

[gaim-migrate @ 9424] "This patch contains two fixes. The first is rather trivial, just removes the declaration of extra pointer used for deleting a message and deletes the message directly. The second is the real bug that needed fixing. Short Explanation: The old code only fixed the message that was being displayed, and still sent the original unchecked message to the receiving party. All I did was add a handler to the load_plugin function to make it fix the message being sent as well. Longer Explanation: In my cursory look through the gaim code (warning, <15 minutes) it appears the message pointer send to all the various *-im-msg and *-chat-msg handlers is a copy of the original string each time. This means if you fix the string at one stage (displaying), you have to fix it again at the next (sending). This seems rather inefficient, but hey, it's your client, maybe it was a design feature. Anyway, the spellchk plugin was only fixing the displayed message, and not the message being sent. So I thought my messages were being fixed while those receiving them new I was screwing up. I added substitute_somethingorother handler for the sending-im-msg callback in the load_plugin function. Other comments: I didn't look to deeply into it since it's so late, but the "displaying-chat-msg" and "sending-chat-msg" callbacks appear to be broken. The spellchk.c currently has a handler registered for the first callback, but the message displayed on my screen still contains the original typos. If I try to register a handler for the second callback listed, Gaim crashes when sending the message to a chat window. As I said, I didn't look into why it was crashing, I just removed my attempt to handle it and built this patch." --Matt Brenneke committer: Tailor Script <tailor@pidgin.im>
author Luke Schierer <lschiere@pidgin.im>
date Fri, 16 Apr 2004 14:39:34 +0000
parents f95edb58087c
children aebfa2b6af6b
line wrap: on
line source

Gaim
Copyright (C) 1998-2004 by the following:

If you have contributed to Gaim, you deserve to be on this list.
Contact us (see: AUTHORS) and we'll add you.

Daniel Atallah
Paul Aurich
Patrick Aussems
Kevin Barry
Brian Bernas
Jonas Birmé
Ethan Blanton
Joshua Blanton
Herman Bloggs
Jason Boerner
Graham Booker
Craig Boston
Chris Boyle
Matt Brenneke
Jeremy Brooks
Philip Brown
Sean Burke
Cerulean Studios, LLC
Ka-Hing Cheung
Arturo Cisneros, Jr.
Vincas Ciziunas
Joe Clarke
Todd Cohen
Felipe Contreras
Jeramey Crawford
Mark Doliner
Nuno Donato
Jim Duchek
Tom Dyas
Marc E.
Andrew Echols
Sean Egan <sean.egan@binghamton.edu>
Brian Enigma
Stefan Esser
Larry Ewing
Jesse Farmer
Gavan Fantom (gavan)
Rob Flynn <gaim@robflynn.com>
Rob (rwf) Foehl
Nathan Fredrickson
Chris J. Friesen
Free Software Foundation
Decklin Foster
Adam Fritzler
Max G.
Ignacy Gawedzki
Michael Golden
Ryan C. Gordon
Christian Hammond
Benjamin Herrenschmidt
Andy Harrison
G. Sumner Hayes
Mike Heffner
Iain Holmes
Karsten Huneycutt
Akuke Kok
Gary Kramlich
Tero Kuusela
Scott Lamb
Dennis Lambe Jr.
Daniel Larsson
Ho-seok Lee
Moses Lei
Ambrose C. Li
Nicolas Lichtmaier
Artem Litvinovich
Syd Logan
Uli Luckas
Matthew Luckie
Brian Macke
Paolo Maggi
Willian T. Mahan
John Matthews
Ryan McCabe
Kurt McKee
Robert McQueen
Robert Mibus
Benjamin Miller
Kevin Miller
Paul Miller
Arkadiusz Miskiewicz
Andrew Molloy
Padraig O'Briain
Christopher (siege) O'Brien
Nathan (pianocomp81) Owens
Matt Pandina
Ricardo Fernandez Pascual
Havoc Pennington
Ari Pollak
Robey Pointer
Nathan Poznick
Brent Priddy
Federicco Mena Quintero
David Raeman
Etan Reisner
Kristian Rietveld
Pekka Riikonen
Tim Ringenbach
Andrew Rodland
Neil Sanchala
Carsten Schaar
Luke Schierer
Evan Schoenberg
Torrey Searle
Jim Seymour
John Silvestri
Alex Smith
David Smock
Mark Spencer <markster@marko.net>
Lex Spoon
Kevin Stange
David Stoddard
Sun Microsystems
Mårten (fursten) Svantesson
Brian Tarricone
Peter Teichman
Philip Tellis
Arun A. Tharuvai
Douglas (douglaswth) Thrift
Stu Tomlinson
Bill Tompkins
Tom Tromey
Chris Toshok
Junichi Uekawa
David Vermeille
Bjoern Voigt
Nathan Walp
Eric Warmenhoven
Andrew Wellington
Dan Willemsen
Jason Willis
Matt Wilson
Ximian
Jared Yanovich
Nickolai Zeldovich
Marco Ziech
Jaroen Zwartepoorte