Mercurial > pidgin.yaz
view gaim.spec.in @ 8672:142108e89399
[gaim-migrate @ 9424]
"This patch contains two fixes. The first is rather trivial, just removes
the declaration of extra pointer used for deleting a message and
deletes the message directly.
The second is the real bug that needed fixing.
Short Explanation:
The old code only fixed the message that was being displayed, and
still sent the original unchecked message to the receiving party. All I
did was add a handler to the load_plugin function to make it fix the
message being sent as well.
Longer Explanation:
In my cursory look through the gaim code (warning, <15 minutes) it
appears the message pointer send to all the various *-im-msg and
*-chat-msg handlers is a copy of the original string each time. This
means if you fix the string at one stage (displaying), you have to fix it
again at the next (sending). This seems rather inefficient, but hey, it's
your client, maybe it was a design feature.
Anyway, the spellchk plugin was only fixing the displayed
message, and not the message being sent. So I thought my messages
were being fixed while those receiving them new I was screwing up. I
added substitute_somethingorother handler for the sending-im-msg
callback in the load_plugin function.
Other comments:
I didn't look to deeply into it since it's so late, but the
"displaying-chat-msg" and "sending-chat-msg" callbacks appear to
be broken. The spellchk.c currently has a handler registered for the
first callback, but the message displayed on my screen still contains
the original typos. If I try to register a handler for the second callback
listed, Gaim crashes when sending the message to a chat window. As
I said, I didn't look into why it was crashing, I just removed my
attempt to handle it and built this patch." --Matt Brenneke
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Fri, 16 Apr 2004 14:39:34 +0000 |
parents | 2a9e8ba61ec7 |
children | 63f07fa577eb |
line wrap: on
line source
Summary: A Gtk+ based multiprotocol instant messaging client Name: @PACKAGE@ Version: @VERSION@ Release: 0 Epoch: 1 License: GPL Group: Applications/Internet URL: http://gaim.sourceforge.net/ Packager: %{packager} Source: %{name}-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-root %if "%{_vendor}" == "MandrakeSoft" Requires: gtk+2.0 >= 2.0.0, libnss3 BuildRequires: libao-devel, libgtk+2.0_0-devel, gtkspell-devel, libtool, audiofile-devel, pkgconfig, libnss3-devel, perl-devel Provides: libgaim-remote0 %else Requires: gtk2 >= 2.0.0, mozilla-nss, gtkspell, audiofile, libao BuildRequires: libao-devel, gtk2-devel, gtkspell-devel, libtool, audiofile-devel, pkgconfig, mozilla-nss-devel %endif %package devel Summary: Development headers, documentation, and libraries for Gaim. Group: Applications/Internet %description Gaim allows you to talk to anyone using a variety of messaging protocols, including AIM (Oscar and TOC), ICQ, IRC, Yahoo!, MSN Messenger, Jabber, Gadu-Gadu, Napster, and Zephyr. These protocols are implemented using a modular, easy to use design. To use a protocol, just add an account using the account editor. Gaim supports many common features of other clients, as well as many unique features, such as perl scripting, TCL scripting and C plugins. Gaim is NOT affiliated with or endorsed by America Online, Inc., Microsoft Corporation, Yahoo! Inc., or ICQ Inc. %description devel The gaim-devel package contains the header files, developer documentation, and libraries required for development of gaim scripts and plugins. %prep %setup %build CFLAGS="$RPM_OPT_FLAGS" ./configure --prefix=%{_prefix} \ --bindir=%{_bindir} \ --datadir=%{_datadir} \ --includedir=%{_includedir} \ --libdir=%{_libdir} \ --mandir=%{_mandir} \ --sysconfdir=%{_sysconfdir} \ --with-perl-lib=%{buildroot}%{_prefix} make %{?_smp_mflags} %install rm -rf %{buildroot} make prefix=%{buildroot}%{_prefix} bindir=%{buildroot}%{_bindir} \ datadir=%{buildroot}%{_datadir} includedir=%{buildroot}%{_includedir} \ libdir=%{buildroot}%{_libdir} mandir=%{buildroot}%{_mandir} \ sysconfdir=%{buildroot}%{_sysconfdir} \ install rm -f $RPM_BUILD_ROOT/%{_libdir}/perl5/*/*/perllocal.pod %clean rm -rf %{buildroot} %files %defattr(-, root, root) %doc doc/the_penguin.txt doc/CREDITS NEWS COPYING AUTHORS COPYRIGHT %doc README ChangeLog %doc %{_mandir}/man1/* %doc %{_mandir}/man3*/* %dir %{_libdir}/gaim %attr(755, root, root) %{_libdir}/gaim/* %attr(755, root, root) %{_libdir}/libgaim-remote.so.* %attr(755, root, root) %{_libdir}/perl5 %{_bindir}/* %{_datadir}/locale/*/*/* %{_datadir}/pixmaps/* %dir %{_datadir}/sounds/gaim %{_datadir}/sounds/gaim/* %{_datadir}/applications/* %files devel %doc plugins/HOWTO %doc HACKING PROGRAMMING_NOTES %attr(755, root, root) %{_libdir}/libgaim-remote.la %dir %{_includedir}/gaim-remote %{_includedir}/gaim-remote/*.h %changelog * Thu Jan 15 2004 Ethan Blanton <eblanton@cs.ohiou.edu> - Removed the manual strip command, as it seems to be unwarranted if the necessary programs are properly installed. (For me, this was elfutils.) * Sun Jul 20 2003 Bjoern Voigt <bjoern@cs.tu-berlin.de> - Added pkgconfig build dependency. - if "%{_vendor}" != "MandrakeSoft" now also works with rpm 3.x. - Added Gaim-specific directories to list of Gaim's files. * Wed Jul 16 2003 Ethan Blanton <eblanton@cs.ohiou.edu> - Complete spec file rewrite to take advantage of "new" RPM features and make things prettier. - Use system-supplied %%{_prefix}, %%{_datadir}, etc. rather than attempt to define our own.