Mercurial > pidgin.yaz
view src/xmlnode.h @ 8672:142108e89399
[gaim-migrate @ 9424]
"This patch contains two fixes. The first is rather trivial, just removes
the declaration of extra pointer used for deleting a message and
deletes the message directly.
The second is the real bug that needed fixing.
Short Explanation:
The old code only fixed the message that was being displayed, and
still sent the original unchecked message to the receiving party. All I
did was add a handler to the load_plugin function to make it fix the
message being sent as well.
Longer Explanation:
In my cursory look through the gaim code (warning, <15 minutes) it
appears the message pointer send to all the various *-im-msg and
*-chat-msg handlers is a copy of the original string each time. This
means if you fix the string at one stage (displaying), you have to fix it
again at the next (sending). This seems rather inefficient, but hey, it's
your client, maybe it was a design feature.
Anyway, the spellchk plugin was only fixing the displayed
message, and not the message being sent. So I thought my messages
were being fixed while those receiving them new I was screwing up. I
added substitute_somethingorother handler for the sending-im-msg
callback in the load_plugin function.
Other comments:
I didn't look to deeply into it since it's so late, but the
"displaying-chat-msg" and "sending-chat-msg" callbacks appear to
be broken. The spellchk.c currently has a handler registered for the
first callback, but the message displayed on my screen still contains
the original typos. If I try to register a handler for the second callback
listed, Gaim crashes when sending the message to a chat window. As
I said, I didn't look into why it was crashing, I just removed my
attempt to handle it and built this patch." --Matt Brenneke
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Fri, 16 Apr 2004 14:39:34 +0000 |
parents | b5dbd1839716 |
children | dafebadcf8d2 |
line wrap: on
line source
/** * @file xmlnode.h XML DOM functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GAIM_XMLNODE_H_ #define _GAIM_XMLNODE_H_ typedef enum _XMLNodeType { XMLNODE_TYPE_TAG, XMLNODE_TYPE_ATTRIB, XMLNODE_TYPE_DATA } XMLNodeType; typedef struct _xmlnode { char *name; XMLNodeType type; char *data; size_t data_sz; struct _xmlnode *parent; struct _xmlnode *child; struct _xmlnode *next; } xmlnode; xmlnode *xmlnode_new(const char *name); xmlnode *xmlnode_new_child(xmlnode *parent, const char *name); void xmlnode_insert_child(xmlnode *parent, xmlnode *child); xmlnode *xmlnode_get_child(xmlnode *parent, const char *name); xmlnode *xmlnode_get_child_with_namespace(xmlnode *parent, const char *name, const char *xmlns); xmlnode *xmlnode_get_next_twin(xmlnode *node); void xmlnode_insert_data(xmlnode *parent, const char *data, size_t size); char *xmlnode_get_data(xmlnode *node); void xmlnode_set_attrib(xmlnode *node, const char *attr, const char *value); const char *xmlnode_get_attrib(xmlnode *node, const char *attr); void xmlnode_remove_attrib(xmlnode *node, const char *attr); char *xmlnode_to_str(xmlnode *node, int *len); xmlnode *xmlnode_from_str(const char *str, size_t size); xmlnode *xmlnode_copy(xmlnode *src); void xmlnode_free(xmlnode *node); #endif /* _GAIM_XMLNODE_H_ */