Mercurial > pidgin.yaz
view AUTHORS @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 26 Nov 2005 17:09:29 +0000 |
parents | 03ee9d7360a3 |
children | 1c8ea8f3b84e |
line wrap: on
line source
gaim - the Pimpin' Penguin IM Clone that's Good for the Soul ============================================================ We've got an IRC room now too, #gaim on irc.freenode.net. Come check us out. Active Developers: ------------------ Sean Egan <bj91704@binghamton.edu> - Lead Developer AIM: SeanEgn ICQ: 96642211 MSN: SeanEgn@hotmail.com Yahoo: SeanEgn Jabber: SeanEgn@jabber.org Daniel 'datallah' Atallah Christian 'ChipX86' Hammond - Developer & Webmaster Herman 'Hermanator' Bloggs - Win32 Port Nathan 'faceprint' Walp - Developer Mark 'KingAnt' Doliner - Developer Ethan 'Paco-Paco' Blanton - Developer Tim 'marv' Ringenbach - Developer Luke 'LSchiere' Schierer - Support Etan 'deryni' Reisner - Developer Stu 'nosnilmot' Tomlinson - Developer Gary 'grim' Kramlich - Developer Richard 'rlaager' Laager Crazy Patch Writers: -------------------- Ka-Hing 'javabsp' Cheung Felipe 'shx' Contreras Decklin Foster Peter 'Bleeter' Lawler Robert 'Robot101' McQueen Benjamin Miller Kevin 'SimGuy' Stange Retired: -------- Rob Flynn <gaim@robflynn.com> - Former Maintainer Adam Fritzler - Former libfaim Maintainer Eric Warmenhoven <eric@warmenhoven.org> - Former Lead Developer Jim Duchek <jimduchek@ou.edu> - Former Maintainer Jim Seymour - Former Jabber Developer Mark Spencer <markster@marko.net> - Original Author Syd Logan - Hacker and Designated Driver (lazy bum)