Mercurial > pidgin.yaz
view plugins/Makefile.am @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 26 Nov 2005 17:09:29 +0000 |
parents | 9096f56b725f |
children | a1e241dd50b6 |
line wrap: on
line source
DIST_SUBDIRS = docklet gevolution gestures mono musicmessaging perl ssl tcl ticker if BUILD_GEVOLUTION GEVOLUTION_DIR = gevolution endif if USE_PERL PERL_DIR = perl endif if USE_TCL TCL_DIR = tcl endif if ENABLE_DBUS DBUS_LTLIB = dbus-example.la # Only use music messaging if dbus is enabled MUSICMESSAGING_DIR = musicmessaging endif if USE_MONO MONO_DIR = mono endif SUBDIRS = \ docklet \ $(GEVOLUTION_DIR) \ gestures \ $(MONO_DIR) \ $(MUSICMESSAGING_DIR) \ $(PERL_DIR) \ ssl \ $(TCL_DIR) \ ticker plugindir = $(libdir)/gaim extplacement_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) gaimrc_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) history_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) iconaway_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) idle_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) notify_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) relnot_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) spellchk_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) statenotify_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) timestamp_la_LDFLAGS = -module -avoid-version $(GTK_LIBS) # this can't be in a conditional otherwise automake 1.4 yells dbus_example_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) $(DBUS_LIBS) if PLUGINS plugin_LTLIBRARIES = \ extplacement.la \ gaimrc.la \ history.la \ iconaway.la \ idle.la \ notify.la \ relnot.la \ spellchk.la \ statenotify.la \ timestamp.la \ $(DBUS_LTLIB) extplacement_la_SOURCES = extplacement.c gaimrc_la_SOURCES = gaimrc.c history_la_SOURCES = history.c iconaway_la_SOURCES = iconaway.c idle_la_SOURCES = idle.c notify_la_SOURCES = notify.c relnot_la_SOURCES = relnot.c spellchk_la_SOURCES = spellchk.c statenotify_la_SOURCES = statenotify.c timestamp_la_SOURCES = timestamp.c if ENABLE_DBUS CLEANFILES = dbus-example-bindings.c dbus_example_la_SOURCES = dbus-example.c .PHONY: always $(top_builddir)/src/dbus-types.h: always cd $(@D) && $(MAKE) $(AM_MAKEFLAGS) $(@F) dbus-example-bindings.c: $(top_srcdir)/src/dbus-analyze-functions.py $(dbus_example_la_SOURCES) cat $(srcdir)/$(dbus_example_la_SOURCES) | \ $(PYTHON) $(top_srcdir)/src/dbus-analyze-functions.py --export-only > $@ $(dbus_example_la_OBJECTS) dbus-example.so: dbus-example-bindings.c $(top_builddir)/src/dbus-types.h endif # ENABLE_DBUS endif # PLUGINS EXTRA_DIST = \ ChangeLog HOWTO \ ChangeLog.API \ Makefile.mingw \ contact_priority.c \ filectl.c \ fortuneprofile.pl \ gaim.pl \ gaiminc.c \ gtk-signals-test.c \ ipc-test-client.c \ ipc-test-server.c \ mailchk.c \ pluginpref_example.c \ raw.c \ signals-test.c \ simple.c AM_CPPFLAGS = \ -DDATADIR=\"$(datadir)\" \ -DVERSION=\"$(VERSION)\" \ -I$(top_builddir)/src \ -I$(top_srcdir)/src \ $(DEBUG_CFLAGS) \ $(GTK_CFLAGS) \ $(PLUGIN_CFLAGS) \ $(DBUS_CFLAGS) # # This part allows people to build their own plugins in here. # Yes, it's a mess. # SUFFIXES = .c .so .c.so: $(LIBTOOL) --mode=compile $(CC) -DHAVE_CONFIG_H -I$(top_srcdir) $(AM_CPPFLAGS) $(CFLAGS) -c $< -o tmp$@.lo $(PLUGIN_CFLAGS) $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o libtmp$@.la -rpath $(plugindir) tmp$@.lo $(LIBS) $(LDFLAGS) -module -avoid-version $(PLUGIN_LIBS) @rm -f tmp$@.lo tmp$@.o libtmp$@.la @cp .libs/libtmp$@.so* $@ @rm -f .libs/libtmp$@.*