Mercurial > pidgin.yaz
view libpurple/tests/Makefile.am @ 29240:1be982612d9a
*** Plucked rev 4be2df4f72bd8a55cdae7f2554b73342a497c92f (bcc0147bab874ca52c55ad4900545e17528bf8fd):
There's no need to check type twice here. Also, g_return_if_reached is not
correct since img==NULL is caused by invalid network input and not some
programmer error.
*** Plucked rev 3d02401cf232459fc80c0837d31e05fae7ae5467 (bcc0147bab874ca52c55ad4900545e17528bf8fd):
Using 'if (img==NULL) return;' fails to clean up properly, so invert the
logic of that section.
*** Plucked rev c64a1adc8bda2b4aeaae1f273541afbc4f71b810 (bcc0147bab874ca52c55ad4900545e17528bf8fd):
Each PurpleSmiley has a PurpleStoredImage behind it, so there's no need to
go and create a new one when someone asks for one.
Also, ignore requests for smileys that don't exist in the image store.
author | Daniel Atallah <daniel.atallah@gmail.com> |
---|---|
date | Thu, 07 Jan 2010 23:38:42 +0000 |
parents | 2da9e4266742 |
children | 338eeaf371e2 |
line wrap: on
line source
if HAVE_CHECK TESTS=check_libpurple clean-local: -rm -rf libpurple.. check_PROGRAMS=check_libpurple check_libpurple_SOURCES=\ check_libpurple.c \ tests.h \ test_cipher.c \ test_jabber_jutil.c \ test_qq.c \ test_yahoo_util.c \ test_util.c \ $(top_builddir)/libpurple/util.h check_libpurple_CFLAGS=\ @CHECK_CFLAGS@ \ $(GLIB_CFLAGS) \ $(DEBUG_CFLAGS) \ $(LIBXML_CFLAGS) \ -I.. \ -I$(top_srcdir)/libpurple \ -DBUILDDIR=\"$(top_builddir)\" check_libpurple_LDADD=\ @CHECK_LIBS@ \ $(GLIB_LIBS) \ $(top_builddir)/libpurple/protocols/jabber/libjabber.la \ $(top_builddir)/libpurple/protocols/qq/libqq.la \ $(top_builddir)/libpurple/protocols/yahoo/libymsg.la \ $(top_builddir)/libpurple/libpurple.la endif