Mercurial > pidgin.yaz
view COPYRIGHT @ 12618:204bd8fac61f
[gaim-migrate @ 14954]
SF Patch #1355796 from Sadrul
This fixes the custom smiley bug where your text gets smilies from the other party in the conversation.
This is a bit of a hack, but it fix things until such time as the smiley tree stuff can be reworked.
" From the kwiki:
If someone uses an MSN smiley, it shows up when I type
the textual representation of it. For example, someone
set a smiley (a rainbow flashy question mark) for ? and
it showed up (on my side, I have no idea about theirs)
for every ? I typed. /luke as I understand this report,
the problem is that the custom smiley should be
restricted to exactly one conversation but is in fact
spanning the account/
* (sadrul) It appears what happens is, the custom
smiley is added to the smiley-tree for that
conversation-imhtml. So whenever any new message is
going to be added to the imhtml, it looks up the
smiley-tree first, and since the "?" (or anything else)
matches the smiley, it converts it to the smiley. At
first glance, it seems the fix would be non-trivial. It
will probably be necessary to distinguish between
custom-smileys (and also messages added to the imhtml)
of the sender and the receiver.
==== end ====
What this patch does is, it temporarily replaces the
smiley-tree for the conversation-imhtml with the
smiley-tree of the conversation-entrybox. I think this
will work because the smiley-trees of both these
imhtml-s are initially the same. When a custom smiley
is received, it is added the smiley-tree of the
conversation-imhtml. So temporarily restoring the
smiley-tree with the original smiley-tree (that in
conv-entrybox) should fix the problem."
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Thu, 22 Dec 2005 04:07:21 +0000 |
parents | 5cfc53ead482 |
children | 87e95b8ce60b |
line wrap: on
line source
Gaim Copyright (C) 1998-2005 by the following: If you have contributed to Gaim, you deserve to be on this list. Contact us (see: AUTHORS) and we'll add you. Dave Ahlswede Manuel Amador Matt Amato Daniel Atallah Paul Aurich Patrick Aussems John Bailey Luca Barbato Levi Bard Kevin Barry Derek Battams Martin Bayard Curtis Beattie Dave Bell Igor Belyi Brian Bernas Jonas Birmé Eric Blade Ethan Blanton Joshua Blanton Rainer Blessing Herman Bloggs David Blue Jason Boerner Graham Booker Paolo Borelli Craig Boston Chris Boyle Derrick J Brashear Matt Brenneke Jeremy Brooks Philip Brown Sean Burke Thomas Butter Michael Carlson Julien Cegarra Cerulean Studios, LLC Jonathan Champ Ka-Hing Cheung Sadrul Habib Chowdhury Arturo Cisneros, Jr. Vincas Ciziunas Jonathan Clark Joe Clarke Eoin Coffey Jason Cohen Todd Cohen Nathan Conrad Felipe Contreras Alex Converse Irving Cordova Adam Cowell Palmer Cox Jeramey Crawford Balwinder Singh Dheeman Finlay Dobbie Mark Doliner Nuno Donato Jim Duchek Alex Duggan Tom Dyas Marc E. Andrew Echols John Eckerdal Sean Egan <seanegan@gmail.com> Nelson Elhage Ignacio J. Elia Brian Enigma Stefan Esser Marc Etcheverry Larry Ewing Gábor Farkas Jesse Farmer Gavan Fantom (gavan) David Fiander Rob Flynn <gaim@robflynn.com> Rob Foehl (rwf) Alan Ford Nathan Fredrickson Chris J. Friesen Free Software Foundation Decklin Foster Francesco Fracassi Adam Fritzler Max G. François Gagné Evgueni V. Gavrilov Ignacy Gawedzki Gustavo Giráldez Richard Gobeille Michael Golden Charlie Gordon Ryan C. Gordon Miah Gregory Christian Hammond Erick Hamness Fred Hampton Casey Harkins Andy Harrison Andrew Hart (arhart) G. Sumner Hayes Michael R. Head Mike Heffner Benjamin Herrenschmidt Fernando Herrera Casey Ho Iain Holmes Joshua Honeycutt Nigel Horne Magnus Hult Karsten Huneycutt Rian Hunter Thomas Huriaux Henry Jen Benjamin Kahn Praveen Karadakal Akuke Kok Cole Kowalski Gary Kramlich Patrik Kullman Tuomas Kuosmanen Tero Kuusela Richard Laager Scott Lamb Dennis Lambe Jr. Joe LaPenna Steve Láposi Daniel Larsson Peter Lawler Ho-seok Lee Moses Lei Ambrose C. Li Nicolas Lichtmaier Artem Litvinovich Syd Logan Lokheed Norberto Lopes Uli Luckas Matthew Luckie Mike Lundy Brian Macke Paolo Maggi Willian T. Mahan Kris Marsh Fidel Martinez Lalo Martins John Matthews Ryan McCabe Peter McCurdy Kurt McKee Torrey McMahon Robert McQueen Robert Mibus Benjamin Miller Kevin Miller Paul Miller Arkadiusz Miskiewicz Andrew Molloy Sergio Moretto Matthew A. Nicholson Szilard Novaki Novell Padraig O'Briain Christopher O'Brien (siege) Jon Oberheide Ruediger Oertel Gudmundur Bjarni Olafsson Nathan Owens (pianocomp81) Matt Pandina Ricardo Fernandez Pascual Riley Patterson Havoc Pennington Ted Percival Eduardo Pérez Joao Luís Marques Pinto Aleksander Piotrowski Ari Pollak Robey Pointer Nathan Poznick Brent Priddy Federicco Mena Quintero Yosef Radchenko David Raeman Etan Reisner Kristian Rietveld Pekka Riikonen Tim Ringenbach Rhett Robinson Luciano Miguel Ferreira Rocha Andrew Rodland Jason Roth Jean-Francois Roy Sam S. Pradyumna Sampath Arvind Samptur Tom Samstag Neil Sanchala Laurent Sansonetti Alceste Scalas Carsten Schaar Luke Schierer Ralph Schmieder Evan Schoenberg Federico Schwindt Torrey Searle Peter Seebach Don Seiler Leonardo Serra Jim Seymour Joe Shaw Scott Shedden Ettore Simone John Silvestri Craig Slusher Alex Smith Malcolm Smith David Smock Phil Snowberger Eddie Sohn (tr1sk) Sony Computer Entertainment America, Inc. Mark Spencer Lex Spoon Kevin Stange Richard Stellingwerff David Stoddard Sun Microsystems Mårten Svantesson (fursten) Robert T. Brian Tarricone Peter Teichman Philip Tellis Arun A. Tharuvai Cestonaro Thilo Will Thompson Douglas Thrift (douglaswth) Andrew Tinney Jeffery To Warren Togami Stu Tomlinson Bill Tompkins Chris Toshok Ken Tossell Tom Tromey Todd Troxell Brad Turcotte Junichi Uekawa István Váradi Philip Van Hoof Kristof Vansant James Vega David Vermeille Sid Vicious Bjoern Voigt Nathan Walp Eric Warmenhoven Andrew Wellington Adam Wendt Dave West Daniel Westermann-Clark Andrew Whewell Simon Wilkinson Dan Willemsen Jason Willis Matt Wilson Justin Wood Ximian Jared Yanovich Timmy Yee Nickolai Zeldovich Marco Ziech Piotr Zielinski Jeroen Zwartepoorte