Mercurial > pidgin.yaz
view plugins/Makefile.am @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Sun, 30 Nov 2003 05:10:24 +0000 |
parents | 6373f8060d90 |
children | 3eab6ac5e4a7 |
line wrap: on
line source
DIST_SUBDIRS = docklet gaim-remote gestures perl ssl tcl ticker if USE_PERL PERL_DIR = perl endif if USE_TCL TCL_DIR = tcl endif SUBDIRS = docklet gaim-remote gestures $(PERL_DIR) $(TCL_DIR) ssl ticker plugindir = $(libdir)/gaim autorecon_la_LDFLAGS = -module -avoid-version history_la_LDFLAGS = -module -avoid-version iconaway_la_LDFLAGS = -module -avoid-version idle_la_LDFLAGS = -module -avoid-version notify_la_LDFLAGS = -module -avoid-version relnot_la_LDFLAGS = -module -avoid-version spellchk_la_LDFLAGS = -module -avoid-version statenotify_la_LDFLAGS = -module -avoid-version timestamp_la_LDFLAGS = -module -avoid-version if PLUGINS plugin_LTLIBRARIES = \ autorecon.la \ history.la \ iconaway.la \ idle.la \ notify.la \ relnot.la \ spellchk.la \ statenotify.la \ timestamp.la autorecon_la_SOURCES = autorecon.c history_la_SOURCES = history.c iconaway_la_SOURCES = iconaway.c idle_la_SOURCES = idle.c notify_la_SOURCES = notify.c relnot_la_SOURCES = relnot.c spellchk_la_SOURCES = spellchk.c statenotify_la_SOURCES = statenotify.c timestamp_la_SOURCES = timestamp.c endif # PLUGINS EXTRA_DIST = \ ChangeLog HOWTO \ filectl.c \ mailchk.c \ gtik.c \ raw.c \ signals-test.c \ simple.c \ gaim.pl \ fortuneprofile.pl \ Makefile.mingw AM_CPPFLAGS = \ -DDATADIR=\"$(datadir)\" \ -DVERSION=\"$(VERSION)\" \ -I$(top_srcdir)/src \ $(DEBUG_CFLAGS) \ $(GTK_CFLAGS) \ $(PLUGIN_CFLAGS) # # This part allows people to build their own plugins in here. # Yes, it's a mess. # SUFFIXES = .c .so .c.so: $(LIBTOOL) --mode=compile $(CC) -DHAVE_CONFIG_H -I$(top_srcdir) $(AM_CPPFLAGS) $(CFLAGS) -c $< -o tmp$@.lo $(PLUGIN_CFLAGS) $(LIBTOOL) --mode=link $(CC) $(CFLAGS) -o libtmp$@.la -rpath $(plugindir) tmp$@.lo $(LIBS) $(LDFLAGS) -module -avoid-version $(PLUGIN_LIBS) @rm -f tmp$@.lo tmp$@.o libtmp$@.la @cp .libs/libtmp$@.so* $@ @rm -f .libs/libtmp$@.*