Mercurial > pidgin.yaz
view plugins/history.c @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Sun, 30 Nov 2003 05:10:24 +0000 |
parents | 25488bd0d461 |
children | 9e122b8f564f |
line wrap: on
line source
/* Puts last 4k of log in new conversations a la Everybuddy (and then * stolen by Trillian "Pro") */ #include "gtkinternal.h" #include "conversation.h" #include "debug.h" #include "log.h" #include "prefs.h" #include "signals.h" #include "util.h" #include "gtkconv.h" #include "gtkimhtml.h" #include "gtkplugin.h" #define HISTORY_PLUGIN_ID "gtk-history" #define HISTORY_SIZE (4 * 1024) static void historize(GaimConversation *c) { GaimGtkConversation *gtkconv; char *history = NULL; guint flags; GtkIMHtmlOptions options = GTK_IMHTML_NO_COLOURS; GtkTextIter end; GList *logs = gaim_log_get_logs(gaim_conversation_get_name(c), gaim_conversation_get_account(c)); if (!logs) return; history = gaim_log_read((GaimLog*)logs->data, &flags); gtkconv = GAIM_GTK_CONVERSATION(c); if (flags & GAIM_LOG_READ_NO_NEWLINE) options |= GTK_IMHTML_NO_NEWLINE; gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), history, options); gtk_imhtml_append_text(GTK_IMHTML(gtkconv->imhtml), "<hr>", options); gtk_text_buffer_get_end_iter(GTK_IMHTML(gtkconv->imhtml)->text_buffer, &end); gtk_text_view_scroll_to_iter(GTK_TEXT_VIEW(gtkconv->imhtml), &end, 0, TRUE, 0, 0); g_free(history); while (logs) { GaimLog *log = logs->data; GList *logs2; g_free(log->name); g_free(log); logs2 = logs->next; g_list_free_1(logs); logs = logs2; } } static gboolean plugin_load(GaimPlugin *plugin) { gaim_signal_connect(gaim_conversations_get_handle(), "conversation-created", plugin, GAIM_CALLBACK(historize), NULL); return TRUE; } static GaimPluginInfo info = { 2, GAIM_PLUGIN_STANDARD, GAIM_GTK_PLUGIN_TYPE, 0, NULL, GAIM_PRIORITY_DEFAULT, HISTORY_PLUGIN_ID, N_("History"), VERSION, N_("Shows recently logged conversations in new conversations."), N_("When a new conversation is opened this plugin will insert the last conversation into the current conversation."), "Sean Egan <bj91704@binghamton.edu>", GAIM_WEBSITE, plugin_load, NULL, NULL, NULL, NULL }; static void init_plugin(GaimPlugin *plugin) { } GAIM_INIT_PLUGIN(history, init_plugin, info)