Mercurial > pidgin.yaz
view src/themes.c @ 7667:30593bf56e71
[gaim-migrate @ 8311]
(23:56:25) shx: LSchiere: there's something wrong in my patch
(23:56:34) Luke: okay
(23:56:38) Luke: what's that
(23:57:45) shx: I forgot to add a '0' a the end of a string
(23:57:56) shx: in the gaim_mime_decode_field funcition
(23:59:35) Luke: where in that?
(00:00:16) shx: at the end, just before this
(00:00:18) shx: if (*unencoded_start)
(00:00:19) shx: n = strcpy(n, unencoded_start);
(00:00:27) shx: whould be this
(00:00:28) shx: *n = '\0';
(00:01:05) Luke: so you are just setting it to NULL
(00:01:53) Luke: i don't understand why you need that n set at all inside
that if, since you just return new on the next line down
(00:03:35) shx: I doing some test right now, but I remember I added that
because I had of some errors
(00:05:04) Luke: i think what you may be hitting is a functional work
around for not properly initializing variables, something that shouldn't
work but does. because you shouldn't need to set something just before you
return unless you are returning IT (or unless you are using staticly
declared memory, in which case you might concievably be using that variable
again when you next enter the function
(00:05:55) shx: no
(00:06:18) shx: n is a pointer to the end of the string, and changes as the
while goes on
(00:06:37) Luke: ah
(00:06:42) shx: n doesn't matter
(00:07:01) Luke: so should the *n = '\0' be inside the if or outside it?
(00:07:30) shx: before the if
(00:07:44) shx: *n = '\0';
(00:07:45) shx: if (*unencoded_start)
(00:07:45) shx: n = strcpy(n, unencoded_start);
(00:08:07) shx: in the case there is no *unencoded_start
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Sun, 30 Nov 2003 05:10:24 +0000 |
parents | 338147ea6896 |
children | 662a33ce4343 |
line wrap: on
line source
/* * Themes for Gaim * * Copyright (C) 2003, Sean Egan <bj91704@binghamton.edu> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "gtkinternal.h" #include "conversation.h" #include "debug.h" #include "prpl.h" #include "util.h" #include "gtkconv.h" #include "gtkimhtml.h" #include "ui.h" struct smiley_list { char *sml; GSList *smileys; struct smiley_list *next; }; GSList *smiley_themes = NULL; struct smiley_theme *current_smiley_theme; void smiley_themeize(GtkWidget *imhtml) { struct smiley_list *list; if (!current_smiley_theme) return; gtk_imhtml_remove_smileys(GTK_IMHTML(imhtml)); list = current_smiley_theme->list; while (list) { char *sml = !strcmp(list->sml, "default") ? NULL : list->sml; GSList *icons = list->smileys; while (icons) { gtk_imhtml_associate_smiley(GTK_IMHTML(imhtml), sml, icons->data); icons = icons->next; } list = list->next; } } void load_smiley_theme(const char *file, gboolean load) { FILE *f = fopen(file, "r"); char buf[256]; char *i; struct smiley_theme *theme=NULL; struct smiley_list *list = NULL; GSList *lst = smiley_themes; char *dirname; if (!f) return; while (lst) { struct smiley_theme *thm = lst->data; if (!strcmp(thm->path, file)) { theme = thm; break; } lst = lst->next; } if (!theme) { theme = g_new0(struct smiley_theme, 1); theme->path = g_strdup(file); smiley_themes = g_slist_append(smiley_themes, theme); } dirname = g_path_get_dirname(file); if (load) { if (current_smiley_theme) { GSList *already_freed = NULL; struct smiley_list *wer = current_smiley_theme->list, *wer2; while (wer) { while (wer->smileys) { GtkIMHtmlSmiley *uio = wer->smileys->data; if (uio->icon) g_object_unref(uio->icon); if (!g_slist_find(already_freed, uio->file)) { g_free(uio->file); already_freed = g_slist_append(already_freed, uio->file); } g_free(uio->smile); g_free(uio); wer->smileys=g_slist_remove(wer->smileys, uio); } wer2 = wer->next; g_free(wer->sml); g_free(wer); wer = wer2; } current_smiley_theme->list = NULL; g_slist_free(already_freed); } current_smiley_theme = theme; } while (!feof(f)) { if (!fgets(buf, sizeof(buf), f)) { break; } if (buf[0] == '#' || buf[0] == '\0') continue; i = buf; while (isspace(*i)) i++; if (*i == '[' && strchr(i, ']') && load) { struct smiley_list *child = g_new0(struct smiley_list, 1); child->sml = g_strndup(i+1, strchr(i, ']') - i - 1); if (theme->list) list->next = child; else theme->list = child; list = child; } else if (!g_ascii_strncasecmp(i, "Name=", strlen("Name="))) { if(theme->name) g_free(theme->name); theme->name = g_strdup(i+ strlen("Name=")); theme->name[strlen(theme->name)-1] = 0; } else if (!g_ascii_strncasecmp(i, "Description=", strlen("Description="))) { if(theme->desc) g_free(theme->desc); theme->desc = g_strdup(i + strlen("Description=")); theme->desc[strlen(theme->desc)-1] = 0; } else if (!g_ascii_strncasecmp(i, "Icon=", strlen("Icon="))) { if(theme->icon) g_free(theme->icon); theme->icon = g_build_filename(dirname, i + strlen("Icon="), NULL); theme->icon[strlen(theme->icon)-1] = 0; } else if (!g_ascii_strncasecmp(i, "Author=", strlen("Author="))) { if(theme->author) g_free(theme->author); theme->author = g_strdup(i + strlen("Author=")); theme->author[strlen(theme->author)-1] = 0; } else if (load && list) { gboolean hidden = FALSE; char *sfile = NULL; if (*i == '!' && *(i + 1) == ' ') { hidden = TRUE; i = i + 2; } while (*i) { char l[64]; int li = 0; while (!isspace(*i)) l[li++] = *(i++); if (!sfile) { l[li] = 0; sfile = g_build_filename(dirname, l, NULL); } else { GtkIMHtmlSmiley *smiley = g_new0(GtkIMHtmlSmiley, 1); l[li] = 0; smiley->file = sfile; smiley->smile = g_strdup(l); smiley->hidden = hidden; list->smileys = g_slist_append(list->smileys, smiley); } while (isspace(*i)) i++; } } } if (load) { GList *cnv; for (cnv = gaim_get_conversations(); cnv != NULL; cnv = cnv->next) { GaimConversation *conv = cnv->data; if (GAIM_IS_GTK_CONVERSATION(conv)) smiley_themeize(GAIM_GTK_CONVERSATION(conv)->imhtml); } } g_free(dirname); fclose(f); } void smiley_theme_probe() { GDir *dir; const gchar *file; gchar *path; int l; char* probedirs[3]; probedirs[0] = g_build_filename(DATADIR, "pixmaps", "gaim", "smileys", NULL); probedirs[1] = g_build_filename(gaim_user_dir(), "smileys", NULL); probedirs[2] = 0; for (l=0; probedirs[l]; l++) { dir = g_dir_open(probedirs[l], 0, NULL); if (dir) { while ((file = g_dir_read_name(dir))) { path = g_build_filename(probedirs[l], file, "theme", NULL); /* Here we check to see that the theme has proper syntax. * We set the second argument to FALSE so that it doesn't load * the theme yet. */ load_smiley_theme(path, FALSE); g_free(path); } g_dir_close(dir); } else if (l == 1) { mkdir(probedirs[l], S_IRUSR | S_IWUSR | S_IXUSR); } g_free(probedirs[l]); } } GSList *get_proto_smileys(int protocol) { GaimPlugin *proto = gaim_find_prpl(protocol); struct smiley_list *list, *def; if(!current_smiley_theme) return NULL; def = list = current_smiley_theme->list; while(list) { if(!strcmp(list->sml, "default")) def = list; else if(proto && !strcmp(proto->info->name, list->sml)) break; list = list->next; } return list ? list->smileys : def->smileys; }