Mercurial > pidgin.yaz
view pidgin/gtkaccount.h @ 16628:36981d83b20c
Fix a crash when removing a per-account icon. Here's my explanation:
21:45:22 rlaager: Since we're not saving the buddy icon path to disk (which, as I mentioned earlier, only exists because of QQ), we end up with that being NULL, which is fine.
21:46:08 rlaager: Where fine = fine, as long as we don't care about QQ and if we do, my changes didn't change that behavior, so it's no worse. ;)
21:46:33 rlaager: The crash in the buddy icon code happens because filename is NULL. In that case, we can return, because the image_deleting_cb is only concerned with those PurpleStoredImages that were created by the buddy icon code. I'll commit the fix.
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 29 Apr 2007 02:49:23 +0000 |
parents | 247e421c4fa6 |
children | 44b4e8bd759b |
line wrap: on
line source
/** * @file gtkaccount.h GTK+ Account Editor UI * @ingroup pidgin * * pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _PIDGINACCOUNT_H_ #define _PIDGINACCOUNT_H_ #include "account.h" typedef enum { PIDGIN_ADD_ACCOUNT_DIALOG, PIDGIN_MODIFY_ACCOUNT_DIALOG } PidginAccountDialogType; /** * Shows the accounts window. */ void pidgin_accounts_window_show(void); /** * Hides the accounts window. */ void pidgin_accounts_window_hide(void); /** * Shows an add/modify account dialog. * * @param type The type of dialog. * @param account The associated account, or @c NULL for an Add dialog. */ void pidgin_account_dialog_show(PidginAccountDialogType type, PurpleAccount *account); /** * Returns the GTK+ account UI ops * * @return The UI operations structure. */ PurpleAccountUiOps *pidgin_accounts_get_ui_ops(void); /** * Returns the gtkaccounts handle * * @return The handle to the GTK+ account system */ void *pidgin_account_get_handle(void); /** * Initializes the GTK+ account system */ void pidgin_account_init(void); /** * Uninitializes the GTK+ account system */ void pidgin_account_uninit(void); #endif /* _PIDGINACCOUNT_H_ */