Mercurial > pidgin.yaz
view src/protocols/msn/group.h @ 13914:3ae8a3935406
[gaim-migrate @ 16414]
First stab at trying to fix the MSN http connect method. It still
doesn't work, and I'm not sure why, but it gets a lot farther in
the signon process now.
For those unfamiliar with the issue, the MSN http connect method
stopped working after all the non-blocking I/O changes. The http
connect method is apparently used by lots of people behind silly
firewalls and stuff, and therefore we really shouldn't release
Gaim 2.0.0 without it working, because people will complain.
The two main problems were
1. The outgoing message queue was removed in favor of buffering all
data to one large buffer. This sounds good in theory... but apparently
each message sent to and from the server has a "SessionID" in the
HTTP header. Every message we send should use the same SessionID as
the last packet we received from the server. So basically you can't
put two messages into the outgoing buffer at the same time because
you don't have the correct SessionID to use for the second message.
You have to wait until you get the reply from the server.
2. There were some strange buffer problems with using the wrong
variable when trying to combine the header+body into one buffer
before sending the message.
I also fixed a small memleak or two, added some comments, and
tried to clean up the code a little.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 03 Jul 2006 20:39:04 +0000 |
parents | ab6636c5a136 |
children | 852b32710df0 |
line wrap: on
line source
/** * @file group.h Group functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _MSN_GROUP_H_ #define _MSN_GROUP_H_ typedef struct _MsnGroup MsnGroup; #include <stdio.h> #include "session.h" #include "user.h" #include "userlist.h" /** * A group. */ struct _MsnGroup { MsnSession *session; /**< The MSN session. */ int id; /**< The group ID. */ char *name; /**< The name of the group. */ }; /**************************************************************************/ /** @name Group API */ /**************************************************************************/ /*@{*/ /** * Creates a new group structure. * * @param session The MSN session. * @param id The group ID. * @param name The name of the group. * * @return A new group structure. */ MsnGroup *msn_group_new(MsnUserList *userlist, int id, const char *name); /** * Destroys a group structure. * * @param group The group to destroy. */ void msn_group_destroy(MsnGroup *group); /** * Sets the ID for a group. * * @param group The group. * @param id The ID. */ void msn_group_set_id(MsnGroup *group, int id); /** * Sets the name for a group. * * @param group The group. * @param name The name. */ void msn_group_set_name(MsnGroup *group, const char *name); /** * Returns the ID for a group. * * @param group The group. * * @return The ID. */ int msn_group_get_id(const MsnGroup *group); /** * Returns the name for a group. * * @param group The group. * * @return The name. */ const char *msn_group_get_name(const MsnGroup *group); #endif /* _MSN_GROUP_H_ */