Mercurial > pidgin.yaz
view pidgin/gtksound.h @ 31677:43f661bc82ed
Fixes this crash:
1. Open an IM window with someone who has just gone online or offline
2. Delete your account from the Accounts window
3. Wait for the 11 second timer to trigger
The conversation code was setting an 11 second timer when a buddy signs
online or offline so that it could stop showing the open door or close
door icon for the buddy, similar to what we do in the buddy list. However,
we didn't keep track of the handle for this timer and didn't clear it if
the account is deleted--thus the crash.
I noticed that we don't currently show the open door or close door icons
in the conversation window. I think it would be good if we did... but
I don't think the gtkconv code should keep track of this information.
gtkblist.c already keeps track of it in gtknode->recent_signonoff_timer.
We should either re-use that, or better yet, we should add "recent signon"
and "recent signoff" states to the status system somehow.
But I don't feel like working on that... it's pretty minor. In any case
I don't think this code is the right way to handle it, so I'm getting
rid of it. Feel free to disapprove this if you disagree! (But also please
fix the crash, maybe just by disabling the timer for now)
I'm also getting rid of the login_list and logout_list lists, since they're
not used.
1 file changed, 33 deletions(-)
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Fri, 18 Feb 2011 07:51:43 +0000 |
parents | d25cbbea7fe5 |
children | 02a2e8183b1d |
line wrap: on
line source
/** * @file gtksound.h GTK+ Sound API * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGINSOUND_H_ #define _PIDGINSOUND_H_ #include "sound.h" /**************************************************************************/ /** @name GTK+ Sound API */ /**************************************************************************/ /*@{*/ /** * Get the prefs option for an event. * * @param event The event. * @return The option. */ const char *pidgin_sound_get_event_option(PurpleSoundEventID event); /** * Get the label for an event. * * @param event The event. * @return The label. */ const char *pidgin_sound_get_event_label(PurpleSoundEventID event); /** * Gets GTK+ sound UI ops. * * @return The UI operations structure. */ PurpleSoundUiOps *pidgin_sound_get_ui_ops(void); /** * Get the handle for the GTK+ sound system. * * @return The handle to the sound system */ void *pidgin_sound_get_handle(void); /** * Returns true Pidgin is using customized sounds * * @return TRUE if non default sounds are used. * * @since 2.6.0 */ gboolean pidgin_sound_is_customized(void); /*@}*/ #endif /* _PIDGINSOUND_H_ */