Mercurial > pidgin.yaz
view AUTHORS @ 11701:5d7da4056644
[gaim-migrate @ 13992]
SF Patch #1332870, from corfe83
"In gtkimhtml.c, in function gtk_smiley_tree_destroy, in
the while loop, we go through the tree and add all the
nodes to be deleted to a GSList. However, we add them
by appending them to the list, but the order of the
list doesn't matter. Because GSList's don't keep track
of the last item in the list, this means each step of
the loop (when we append) we are incrementing through
the whole list. In my tests, on closing the preference
box, this loop was gone through more than 1,000 times,
and at many stages this list it is appending to is well
over 50 elements long.
I've changed it to prepend items to the list, which
works just the same (although destroying items in the
tree in a different order), and is much faster (prepend
works in O(1) time, as opposed to O(N) time)."
I think the moral of the story is, when order doesn't matter, use g_[s]list_prepend instead of g_[s]list_append.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Thu, 20 Oct 2005 08:01:03 +0000 |
| parents | 03ee9d7360a3 |
| children | 1c8ea8f3b84e |
line wrap: on
line source
gaim - the Pimpin' Penguin IM Clone that's Good for the Soul ============================================================ We've got an IRC room now too, #gaim on irc.freenode.net. Come check us out. Active Developers: ------------------ Sean Egan <bj91704@binghamton.edu> - Lead Developer AIM: SeanEgn ICQ: 96642211 MSN: SeanEgn@hotmail.com Yahoo: SeanEgn Jabber: SeanEgn@jabber.org Daniel 'datallah' Atallah Christian 'ChipX86' Hammond - Developer & Webmaster Herman 'Hermanator' Bloggs - Win32 Port Nathan 'faceprint' Walp - Developer Mark 'KingAnt' Doliner - Developer Ethan 'Paco-Paco' Blanton - Developer Tim 'marv' Ringenbach - Developer Luke 'LSchiere' Schierer - Support Etan 'deryni' Reisner - Developer Stu 'nosnilmot' Tomlinson - Developer Gary 'grim' Kramlich - Developer Richard 'rlaager' Laager Crazy Patch Writers: -------------------- Ka-Hing 'javabsp' Cheung Felipe 'shx' Contreras Decklin Foster Peter 'Bleeter' Lawler Robert 'Robot101' McQueen Benjamin Miller Kevin 'SimGuy' Stange Retired: -------- Rob Flynn <gaim@robflynn.com> - Former Maintainer Adam Fritzler - Former libfaim Maintainer Eric Warmenhoven <eric@warmenhoven.org> - Former Lead Developer Jim Duchek <jimduchek@ou.edu> - Former Maintainer Jim Seymour - Former Jabber Developer Mark Spencer <markster@marko.net> - Original Author Syd Logan - Hacker and Designated Driver (lazy bum)