Mercurial > pidgin.yaz
view m4macros/gaim.m4 @ 11701:5d7da4056644
[gaim-migrate @ 13992]
SF Patch #1332870, from corfe83
"In gtkimhtml.c, in function gtk_smiley_tree_destroy, in
the while loop, we go through the tree and add all the
nodes to be deleted to a GSList. However, we add them
by appending them to the list, but the order of the
list doesn't matter. Because GSList's don't keep track
of the last item in the list, this means each step of
the loop (when we append) we are incrementing through
the whole list. In my tests, on closing the preference
box, this loop was gone through more than 1,000 times,
and at many stages this list it is appending to is well
over 50 elements long.
I've changed it to prepend items to the list, which
works just the same (although destroying items in the
tree in a different order), and is much faster (prepend
works in O(1) time, as opposed to O(N) time)."
I think the moral of the story is, when order doesn't matter, use g_[s]list_prepend instead of g_[s]list_append.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Thu, 20 Oct 2005 08:01:03 +0000 |
parents | 616feca04ada |
children |
line wrap: on
line source
dnl ########################################################################### dnl # Configure paths for Gaim dnl # Gary Kramlich 2005 dnl # dnl # Based off of glib-2.0.m4 by Owen Taylor dnl ########################################################################### dnl ########################################################################### dnl # AM_PATH_GAIM([MINIMUM-VERSION, [ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND]]]) dnl # dnl # Test for gaim and define GAIM_CFLAGS, GAIM_LIBS, GAIM_DATADIR, and dnl # GAIM_LIBDIR dnl ########################################################################### AC_DEFUN([AM_PATH_GAIM], [dnl AC_PATH_PROG(PKG_CONFIG, pkg-config, no) no_gaim="" if test x"$PKG_CONFIG" != x"no" ; then if $PKG_CONFIG --atleast-pkgconfig-version 0.7 ; then : else echo "*** pkg-config is too old; version 0.7 or newer is required." no_gaim="yes" PKG_CONFIG="no" fi else no_gaim="yes" fi min_version=ifelse([$1], ,2.0.0,$1) found_version="" AC_MSG_CHECKING(for gaim - version >= $min_version) if test x"$no_gaim" = x"" ; then GAIM_DATADIR=`$PKG_CONFIG --variable=datadir gaim` GAIM_LIBDIR=`$PKG_CONFIG --variable=libdir gaim` GAIM_CFLAGS=`$PKG_CONFIG --cflags gaim` GAIM_LIBS=`$PKG_CONFIG --libs gaim` gaim_version=`$PKG_CONFIG --modversion gaim` gaim_major_version=`echo $gaim_version | cut -d. -f 1` gaim_minor_version=`echo $gaim_version | cut -d. -f 2` dnl # stash the micro version in a temp variable. Then stash dnl # the numeric for it in gaim_micro_version and anything dnl # else in gaim_extra_version. gaim_micro_version_temp=`echo $gaim_version | cut -d. -f 3` gaim_micro_version=`echo $gaim_micro_version_temp | sed 's/[[^0-9]]//g'` gaim_extra_version=`echo $gaim_micro_version_temp | sed 's/[[0-9]]//g'` dnl # get the major, minor, and macro that the user gave us min_major_version=`echo $min_version | cut -d. -f 1` min_minor_version=`echo $min_version | cut -d. -f 2` min_micro_version=`echo $min_version | cut -d. -f 3` dnl # check the users version against the version from pkg-config if test $gaim_major_version -eq $min_major_version -a \ $gaim_minor_version -ge $min_minor_version -a \ $gaim_micro_version -ge $min_micro_version then : else no_gaim="yes" found_version="$gaim_major_version.$gaim_minor_version.$gaim_micro_version$gaim_extra_version" fi dnl # Do we want a compile test here? fi if test x"$no_gaim" = x"" ; then AC_MSG_RESULT(yes (version $gaim_major_version.$gaim_minor_version.$gaim_micro_version$gaim_extra_version)) ifelse([$2], , :, [$2]) else AC_MSG_RESULT(no) if test x"$PKG_CONFIG" = x"no" ; then echo "*** A new enough version of pkg-config was not found." echo "*** See http://www.freedesktop.org/software/pkgconfig/" fi if test x"found_version" != x"" ; then echo "*** A new enough version of gaim was not found." echo "*** You have version $found_version" echo "*** See http://gaim.sf.net/" fi GAIM_CFLAGS="" GAIM_LIBS="" GAIM_DATADIR="" GAIM_LIBDIR="" ifelse([$3], , :, [$3]) fi AC_SUBST(GAIM_CFLAGS) AC_SUBST(GAIM_LIBS) AC_SUBST(GAIM_DATADIR) AC_SUBST(GAIM_LIBDIR) ])