view libpurple/protocols/zephyr/zephyr_err.h @ 30702:6829b27ee4c8

This patch attempts to fix four bugs in the oscar protocol plugin that were introduced with the X-Status code in Pidgin 2.7.0. Problem #1 (the remotely-triggerable crash): The crash happens when a buddy sets an xstatus message containing <desc> but no closing </desc>, or <title> but no closing </title>. The fix is to check the result of strstr(closing_tag_name) and do nothing if it is NULL. This is CVE-2010-2528. Problem #2: Fixes potential incorrect parsing of the xstatus string that could result in an incorrect message being displayed to the libpurple user. Happens if an xstatus message contains </desc> before <desc>, or </title> before <title>. The fix is to start looking for the closing tag at the end of the beginning tag rather than at the beginning of the xstatus xml. Probably not a security problem, but definitely a bug. Problem #3: Fixes potential incorrect parsing of the xstatus string that could result in the title not being shown to the libpurple user. Happens if the close title tag appears after the desc tag in the xstatus xml, because we add a null character at the beginning of the close title tag, so strstr() for the desc tag would stop searching there. Probably not a security problem, but definitely a bug. Problem #4: Fixes potential incorrect display of the xstatus string that could result in an incorrect message being displayed to the libpurple user. Happens because we reusing the 'xml' string when preparing the string for the user, but we copy values from xml to xml. If those values overlap with themselves or with each other then an incorrect value could be displayed. Probably not a security problem, but definitely a bug.

/*
 * zephyr_err.h:
 * This file is automatically generated; please do not edit it.
 */
#define ZERR_PKTLEN                              (-772103680L)
#define ZERR_HEADERLEN                           (-772103679L)
#define ZERR_ILLVAL                              (-772103678L)
#define ZERR_HMPORT                              (-772103677L)
#define ZERR_PORTINUSE                           (-772103676L)
#define ZERR_BADPKT                              (-772103675L)
#define ZERR_VERS                                (-772103674L)
#define ZERR_NOPORT                              (-772103673L)
#define ZERR_NONOTICE                            (-772103672L)
#define ZERR_QLEN                                (-772103671L)
#define ZERR_HMDEAD                              (-772103670L)
#define ZERR_INTERNAL                            (-772103669L)
#define ZERR_NOLOCATIONS                         (-772103668L)
#define ZERR_NOMORELOCS                          (-772103667L)
#define ZERR_FIELDLEN                            (-772103666L)
#define ZERR_BADFIELD                            (-772103665L)
#define ZERR_SERVNAK                             (-772103664L)
#define ZERR_AUTHFAIL                            (-772103663L)
#define ZERR_LOGINFAIL                           (-772103662L)
#define ZERR_NOSUBSCRIPTIONS                     (-772103661L)
#define ZERR_NOMORESUBSCRIPTIONS                 (-772103660L)
#define ZERR_TOOMANYSUBS                         (-772103659L)
#define ZERR_EOF                                 (-772103658L)
void initialize_zeph_error_table (void);
#define ERROR_TABLE_BASE_zeph (-772103680L)

/* for compatibility with older versions... */
#define init_zeph_err_tbl initialize_zeph_error_table
#define zeph_err_base ERROR_TABLE_BASE_zeph