Mercurial > pidgin.yaz
view Makefile.mingw @ 7450:685736e14aac
[gaim-migrate @ 8061]
from bug #836143
-----------------------------------------------------------------
Date: 2003-11-06 17:19
Sender: zuperdee
Logged In: YES
user_id=347499
Alright folks, I HAVE A FIX!!!! I repeat, I HAVE A FIX!!!!!!!!!
Basically, this is what was wrong: the
account_win_destroy_cb function was failing to destroy the
window when the "window delete" event was happening.
I
reviewed the code, and it appears there are only 2 places
where that function is called, and in BOTH cases,
gtk_widget_destroy(dialog->window) was called before calling
account_win_destroy_cb. That's ugly!!!! So, my patch
rearranges things so gtk_widget_destroy is called at the
beginning of account_win_destroy_cb. That way, it *DOES*
destroy the window as it is supposed to, and it removes a
couple unnecessary lines of code. Woohoo!!!!!!!!!
I've tested it here on my own system, and it appears to
work, but I'd appreciate it if someone else could verify my
fix before it is checked in (should it be accepted).
The fix is in Patch #837542 here on Sourceforge. :-)
Yours Truly,
Daniel
(Yes, I am excited!!! I just fixed a problem in Gaim that
has been bugging me for some time. I *HATE* instability...
Call me the Segfault Avenger. ;-))
---------------------------------------------------------------
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 06 Nov 2003 23:29:40 +0000 |
parents | c92dbccd7448 |
children | f26e7dc1805e |
line wrap: on
line source
# Makefile.mingw # # Author: hermanator12002@yahoo.com # Date 9/11/02 # Description: Top Makefile for win32 (mingw) port of Gaim # GAIM_SRC = ./src GAIM_PROTOS = $(GAIM_SRC)/protocols GAIM_PLUGINS = ./plugins GAIM_PIXMAPS = ./pixmaps GAIM_SOUNDS = ./sounds GAIM_INSTALL_DIR = ./win32-install-dir GTKSPELL_TOP = ../win32-dev/gtkspell-2.0.4/gtkspell IDLETRACK_TOP = $(GAIM_SRC)/win32/IdleTracker GTKRC_TOP = ../win32-dev/gtkrc OSCAR = $(GAIM_PROTOS)/oscar YAHOO = $(GAIM_PROTOS)/yahoo MSN = $(GAIM_PROTOS)/msn TOC = $(GAIM_PROTOS)/toc IRC = $(GAIM_PROTOS)/irc JABBER = $(GAIM_PROTOS)/jabber NAPSTER = $(GAIM_PROTOS)/napster TREPIA = $(GAIM_PROTOS)/trepia GG = $(GAIM_PROTOS)/gg PO = ./po VERSION := $(shell cat ./VERSION) NEEDED_DLLS = $(GTKSPELL_TOP)/libgtkspell.dll \ $(IDLETRACK_TOP)/idletrack.dll SOUNDS = $(GAIM_SOUNDS)/leave.wav \ $(GAIM_SOUNDS)/redalert.wav \ $(GAIM_SOUNDS)/receive.wav \ $(GAIM_SOUNDS)/send.wav \ $(GAIM_SOUNDS)/arrive.wav ## ## Don't forget to change STATIC_PROTO_INIT, in config.h.mingw if you ## change the status of a protocol (static/plugin) ## OSCAR_TYPE = PLUGIN YAHOO_TYPE = PLUGIN MSN_TYPE = PLUGIN TOC_TYPE = PLUGIN IRC_TYPE = PLUGIN JABBER_TYPE = PLUGIN NAPSTER_TYPE = PLUGIN GG_TYPE = PLUGIN TREPIA_TYPE = PLUGIN all: cp config.h.mingw config.h $(MAKE) TYPE='$(OSCAR_TYPE)' -C $(OSCAR) -f Makefile.mingw $(MAKE) TYPE='$(YAHOO_TYPE)' -C $(YAHOO) -f Makefile.mingw $(MAKE) TYPE='$(MSN_TYPE)' -C $(MSN) -f Makefile.mingw $(MAKE) TYPE='$(TOC_TYPE)' -C $(TOC) -f Makefile.mingw $(MAKE) TYPE='$(IRC_TYPE)' -C $(IRC) -f Makefile.mingw $(MAKE) TYPE='$(JABBER_TYPE)' -C $(JABBER) -f Makefile.mingw $(MAKE) TYPE='$(GG_TYPE)' -C $(GG) -f Makefile.mingw $(MAKE) -C $(GAIM_SRC) -f Makefile.mingw $(MAKE) -C $(GAIM_PLUGINS) -f Makefile.mingw install: all mkdir -p $(GAIM_INSTALL_DIR)/plugins mkdir -p $(GAIM_INSTALL_DIR)/sounds/gaim $(MAKE) -C $(GAIM_PIXMAPS) -f Makefile.mingw install $(MAKE) -C $(PO) -f Makefile.mingw install $(MAKE) -C $(GAIM_SRC) -f Makefile.mingw install $(MAKE) -C $(GAIM_PLUGINS) -f Makefile.mingw install $(MAKE) TYPE='$(OSCAR_TYPE)' -C $(OSCAR) -f Makefile.mingw install $(MAKE) TYPE='$(YAHOO_TYPE)' -C $(YAHOO) -f Makefile.mingw install $(MAKE) TYPE='$(MSN_TYPE)' -C $(MSN) -f Makefile.mingw install $(MAKE) TYPE='$(TOC_TYPE)' -C $(TOC) -f Makefile.mingw install $(MAKE) TYPE='$(IRC_TYPE)' -C $(IRC) -f Makefile.mingw install $(MAKE) TYPE='$(JABBER_TYPE)' -C $(JABBER) -f Makefile.mingw install $(MAKE) TYPE='$(GG_TYPE)' -C $(GG) -f Makefile.mingw install cp $(NEEDED_DLLS) $(GAIM_INSTALL_DIR) cp $(SOUNDS) $(GAIM_INSTALL_DIR)/sounds/gaim installer: makensis.exe /DGAIM_VERSION="$(VERSION)" /DWITH_GTK gaim-installer.nsi installer_nogtk: makensis.exe /DGAIM_VERSION="$(VERSION)" gaim-installer.nsi installer_debug: makensis.exe /DGAIM_VERSION="$(VERSION)" /DDEBUG gaim-installer.nsi installers: installer installer_nogtk clean: $(MAKE) -C $(PO) -f Makefile.mingw clean $(MAKE) -C $(OSCAR) -f Makefile.mingw clean $(MAKE) -C $(YAHOO) -f Makefile.mingw clean $(MAKE) -C $(MSN) -f Makefile.mingw clean $(MAKE) -C $(TOC) -f Makefile.mingw clean $(MAKE) -C $(IRC) -f Makefile.mingw clean $(MAKE) -C $(JABBER) -f Makefile.mingw clean $(MAKE) -C $(GG) -f Makefile.mingw clean $(MAKE) -C $(GAIM_SRC) -f Makefile.mingw clean $(MAKE) -C $(GAIM_PLUGINS) -f Makefile.mingw clean rm -rf config.h $(GAIM_INSTALL_DIR) rm -rf gaim*.exe