Mercurial > pidgin.yaz
view src/buddyicon.c @ 7450:685736e14aac
[gaim-migrate @ 8061]
from bug #836143
-----------------------------------------------------------------
Date: 2003-11-06 17:19
Sender: zuperdee
Logged In: YES
user_id=347499
Alright folks, I HAVE A FIX!!!! I repeat, I HAVE A FIX!!!!!!!!!
Basically, this is what was wrong: the
account_win_destroy_cb function was failing to destroy the
window when the "window delete" event was happening.
I
reviewed the code, and it appears there are only 2 places
where that function is called, and in BOTH cases,
gtk_widget_destroy(dialog->window) was called before calling
account_win_destroy_cb. That's ugly!!!! So, my patch
rearranges things so gtk_widget_destroy is called at the
beginning of account_win_destroy_cb. That way, it *DOES*
destroy the window as it is supposed to, and it removes a
couple unnecessary lines of code. Woohoo!!!!!!!!!
I've tested it here on my own system, and it appears to
work, but I'd appreciate it if someone else could verify my
fix before it is checked in (should it be accepted).
The fix is in Patch #837542 here on Sourceforge. :-)
Yours Truly,
Daniel
(Yes, I am excited!!! I just fixed a problem in Gaim that
has been bugging me for some time. I *HATE* instability...
Call me the Segfault Avenger. ;-))
---------------------------------------------------------------
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 06 Nov 2003 23:29:40 +0000 |
parents | 1c8830db0189 |
children | 20d0c025312a |
line wrap: on
line source
/** * @file icon.c Buddy Icon API * @ingroup core * * gaim * * Copyright (C) 2003 Christian Hammond <chipx86@gnupdate.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "internal.h" #include "buddyicon.h" #include "conversation.h" #include "debug.h" #include "util.h" static GHashTable *account_cache = NULL; static char *cache_dir = NULL; static gboolean icon_caching = TRUE; GaimBuddyIcon * gaim_buddy_icon_new(GaimAccount *account, const char *username, void *icon_data, size_t icon_len) { GaimBuddyIcon *icon; g_return_val_if_fail(account != NULL, NULL); g_return_val_if_fail(username != NULL, NULL); g_return_val_if_fail(icon_data != NULL, NULL); g_return_val_if_fail(icon_len > 0, NULL); icon = gaim_buddy_icons_find(account, username); if (icon == NULL) { GHashTable *icon_cache; icon = g_new0(GaimBuddyIcon, 1); gaim_buddy_icon_set_account(icon, account); gaim_buddy_icon_set_username(icon, username); icon_cache = g_hash_table_lookup(account_cache, account); if (icon_cache == NULL) { icon_cache = g_hash_table_new(g_str_hash, g_str_equal); g_hash_table_insert(account_cache, account, icon_cache); } g_hash_table_insert(icon_cache, (char *)gaim_buddy_icon_get_username(icon), icon); } gaim_buddy_icon_set_data(icon, icon_data, icon_len); gaim_buddy_icon_ref(icon); return icon; } void gaim_buddy_icon_destroy(GaimBuddyIcon *icon) { GaimConversation *conv; GaimAccount *account; GHashTable *icon_cache; const char *username; g_return_if_fail(icon != NULL); if (icon->ref_count > 0) { gaim_buddy_icon_unref(icon); return; } account = gaim_buddy_icon_get_account(icon); username = gaim_buddy_icon_get_username(icon); conv = gaim_find_conversation_with_account(username, account); if (conv != NULL && gaim_conversation_get_type(conv) == GAIM_CONV_IM) gaim_conv_im_set_icon(GAIM_CONV_IM(conv), NULL); icon_cache = g_hash_table_lookup(account_cache, gaim_buddy_icon_get_account(icon)); if (icon_cache != NULL) g_hash_table_remove(icon_cache, gaim_buddy_icon_get_username(icon)); if (icon->username != NULL) g_free(icon->username); if (icon->data != NULL) g_free(icon->data); g_free(icon); } GaimBuddyIcon * gaim_buddy_icon_ref(GaimBuddyIcon *icon) { g_return_val_if_fail(icon != NULL, NULL); icon->ref_count++; return icon; } GaimBuddyIcon * gaim_buddy_icon_unref(GaimBuddyIcon *icon) { g_return_val_if_fail(icon != NULL, NULL); if (icon->ref_count <= 0) return NULL; icon->ref_count--; if (icon->ref_count == 0) { gaim_buddy_icon_destroy(icon); return NULL; } return icon; } void gaim_buddy_icon_update(GaimBuddyIcon *icon) { GaimConversation *conv; GaimAccount *account; const char *username; GSList *sl; g_return_if_fail(icon != NULL); account = gaim_buddy_icon_get_account(icon); username = gaim_buddy_icon_get_username(icon); for (sl = gaim_find_buddies(account, username); sl != NULL; sl = sl->next) { GaimBuddy *buddy = (GaimBuddy *)sl->data; gaim_buddy_set_icon(buddy, icon); } conv = gaim_find_conversation_with_account(username, account); if (conv != NULL && gaim_conversation_get_type(conv) == GAIM_CONV_IM) gaim_conv_im_set_icon(GAIM_CONV_IM(conv), icon); } void gaim_buddy_icon_cache(GaimBuddyIcon *icon, GaimBuddy *buddy) { const void *data; const char *dirname; char *random; char *filename; const char *old_icon; size_t len; FILE *file = NULL; g_return_if_fail(icon != NULL); g_return_if_fail(buddy != NULL); if (!gaim_buddy_icons_is_caching()) return; data = gaim_buddy_icon_get_data(icon, &len); random = g_strdup_printf("%x", g_random_int()); dirname = gaim_buddy_icons_get_cache_dir(); filename = g_build_filename(dirname, random, NULL); old_icon = gaim_buddy_get_setting(buddy, "buddy_icon"); g_free(random); if (!g_file_test(dirname, G_FILE_TEST_IS_DIR)) { gaim_debug_info("buddy icons", "Creating icon cache directory.\n"); if (mkdir(dirname, S_IRUSR | S_IWUSR | S_IXUSR) < 0) { gaim_debug_error("buddy icons", "Unable to create directory %s: %s\n", dirname, strerror(errno)); } } if ((file = fopen(filename, "wb")) != NULL) { fwrite(data, 1, len, file); fclose(file); } if (old_icon != NULL) unlink(old_icon); gaim_buddy_set_setting(buddy, "buddy_icon", filename); gaim_blist_save(); g_free(filename); } void gaim_buddy_icon_set_account(GaimBuddyIcon *icon, GaimAccount *account) { g_return_if_fail(icon != NULL); g_return_if_fail(account != NULL); icon->account = account; } void gaim_buddy_icon_set_username(GaimBuddyIcon *icon, const char *username) { g_return_if_fail(icon != NULL); g_return_if_fail(username != NULL); if (icon->username != NULL) g_free(icon->username); icon->username = g_strdup(username); } void gaim_buddy_icon_set_data(GaimBuddyIcon *icon, void *data, size_t len) { g_return_if_fail(icon != NULL); if (icon->data != NULL) g_free(icon->data); if (data != NULL && len > 0) { icon->data = g_memdup(data, len); icon->len = len; } else { icon->data = NULL; icon->len = 0; } gaim_buddy_icon_update(icon); } GaimAccount * gaim_buddy_icon_get_account(const GaimBuddyIcon *icon) { g_return_val_if_fail(icon != NULL, NULL); return icon->account; } const char * gaim_buddy_icon_get_username(const GaimBuddyIcon *icon) { g_return_val_if_fail(icon != NULL, NULL); return icon->username; } const void * gaim_buddy_icon_get_data(const GaimBuddyIcon *icon, size_t *len) { g_return_val_if_fail(icon != NULL, NULL); if (len != NULL) *len = icon->len; return icon->data; } void gaim_buddy_icons_set_for_user(GaimAccount *account, const char *username, void *icon_data, size_t icon_len) { g_return_if_fail(account != NULL); g_return_if_fail(username != NULL); gaim_buddy_icon_new(account, username, icon_data, icon_len); } GaimBuddyIcon * gaim_buddy_icons_find(const GaimAccount *account, const char *username) { GHashTable *icon_cache; g_return_val_if_fail(account != NULL, NULL); g_return_val_if_fail(username != NULL, NULL); icon_cache = g_hash_table_lookup(account_cache, account); if (icon_cache == NULL) return NULL; return g_hash_table_lookup(icon_cache, username); } void gaim_buddy_icons_set_caching(gboolean caching) { icon_caching = caching; } gboolean gaim_buddy_icons_is_caching(void) { return icon_caching; } void gaim_buddy_icons_set_cache_dir(const char *dir) { g_return_if_fail(cache_dir != NULL); if (cache_dir != NULL) g_free(cache_dir); cache_dir = g_strdup(dir); } const char * gaim_buddy_icons_get_cache_dir(void) { return cache_dir; } void * gaim_buddy_icons_get_handle() { static int handle; return &handle; } void gaim_buddy_icons_init() { account_cache = g_hash_table_new_full( g_direct_hash, g_direct_equal, NULL, (GFreeFunc)g_hash_table_destroy); cache_dir = g_build_filename(gaim_user_dir(), "icons", NULL); } void gaim_buddy_icons_uninit() { g_hash_table_destroy(account_cache); }