Mercurial > pidgin.yaz
view console/Makefile.am @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Tue, 26 Sep 2006 17:38:09 +0000 |
parents | bcf89a7c69db |
children | be2feab10c71 |
line wrap: on
line source
if ENABLE_GNT SUBDIRS = libgnt plugins bin_PROGRAMS = gaim-text gaim_text_SOURCES = \ gntaccount.c \ gntblist.c \ gntconn.c \ gntconv.c \ gntdebug.c \ gntgaim.c \ gntnotify.c \ gntplugin.c \ gntprefs.c \ gntrequest.c \ gntstatus.c \ gntui.c gaim_text_headers = \ gntaccount.h \ gntblist.h \ gntconn.h \ gntconv.h \ gntdebug.h \ gntgaim.h \ gntnotify.h \ gntplugin.h \ gntprefs.h \ gntrequest.h \ gntstatus.h \ gntui.h gaim_textincludedir=$(includedir)/gaim/gnt gaim_textinclude_HEADERS = \ $(gaim_text_headers) gaim_text_DEPENDENCIES = @LIBOBJS@ $(STATIC_LINK_LIBS) gaim_text_LDFLAGS = -export-dynamic gaim_text_LDADD = \ @LIBOBJS@ \ $(DBUS_LIBS) \ $(STATIC_LINK_LIBS) \ $(INTLLIBS) \ $(GLIB_LIBS) \ $(LIBXML_LIBS) \ $(GNT_LIBS) \ ./libgnt/libgnt.la \ $(top_builddir)/libgaim/libgaim.la AM_CPPFLAGS = \ -DSTANDALONE \ -DBR_PTHREADS=0 \ -DDATADIR=\"$(datadir)\" \ -DLIBDIR=\"$(libdir)/gaim/\" \ -DLOCALEDIR=\"$(datadir)/locale\" \ -DSYSCONFDIR=\"$(sysconfdir)\" \ -I$(top_srcdir)/libgaim/ \ -I$(top_srcdir) \ -I$(srcdir)/libgnt/ \ $(DEBUG_CFLAGS) \ $(GLIB_CFLAGS) \ $(DBUS_CFLAGS) \ $(LIBXML_CFLAGS) \ $(GNT_CFLAGS) endif