Mercurial > pidgin.yaz
view libpurple/eventloop.c @ 24425:7cf760f3560e
Don't try to free NULL xmlnodes stolen by jabber-receiving-xmlnode handlers
Handlers get a (xmlnode **) that they're meant to set to NULL if they steal
the node for their own nefarious purposes, signalling to the prpl that it
should forget about that node. But the prpl still tried to free the xmlnode*
even if it had been NULLified, triggering g_return_if_fail warnings.
Fixes the issue discussed by Arne Knig in
http://pidgin.im/pipermail/devel/2008-November/007035.html and the following
messages.
author | Will Thompson <will.thompson@collabora.co.uk> |
---|---|
date | Fri, 21 Nov 2008 12:12:31 +0000 |
parents | 6bf32c9e15a7 |
children | f1437342cc0e |
line wrap: on
line source
/** * @file eventloop.c Purple Event Loop API * @ingroup core */ /* purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "eventloop.h" #include "internal.h" static PurpleEventLoopUiOps *eventloop_ui_ops = NULL; guint purple_timeout_add(guint interval, GSourceFunc function, gpointer data) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); return ops->timeout_add(interval, function, data); } guint purple_timeout_add_seconds(guint interval, GSourceFunc function, gpointer data) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); if (ops->timeout_add_seconds) return ops->timeout_add_seconds(interval, function, data); else return ops->timeout_add(1000 * interval, function, data); } gboolean purple_timeout_remove(guint tag) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); return ops->timeout_remove(tag); } guint purple_input_add(int source, PurpleInputCondition condition, PurpleInputFunction func, gpointer user_data) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); return ops->input_add(source, condition, func, user_data); } gboolean purple_input_remove(guint tag) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); return ops->input_remove(tag); } int purple_input_get_error(int fd, int *error) { PurpleEventLoopUiOps *ops = purple_eventloop_get_ui_ops(); if (ops->input_get_error) { int ret = ops->input_get_error(fd, error); errno = *error; return ret; } else { socklen_t len; len = sizeof(*error); return getsockopt(fd, SOL_SOCKET, SO_ERROR, error, &len); } } void purple_eventloop_set_ui_ops(PurpleEventLoopUiOps *ops) { eventloop_ui_ops = ops; } PurpleEventLoopUiOps * purple_eventloop_get_ui_ops(void) { g_return_val_if_fail(eventloop_ui_ops != NULL, NULL); return eventloop_ui_ops; }