Mercurial > pidgin.yaz
view .mtn-ignore @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | 8b952cb84f45 |
children | 216f8eb9d82d |
line wrap: on
line source
(.*/)?\.svn .*/?Makefile(\.in)?$ .*/?Makefile\.am\.mingw$ (.*/)?TAGS$ .*/?.*\.pc$ .*/perl/common/[^/]+\.c$ .*/perl/common/blib.* .*/perl/common/pm_to_blib$ .*\.bs$ .*\.def$ .*\.dll$ .*\.exe$ intltool-.* Doxyfile(\.mingw)?$ aclocal.m4 compile config.cache config.guess config.h$ config.h.in config.log config.status config.sub configure$ finch/finch$ finch/libgnt/gntmarshal.c finch/libgnt/gntmarshal.h depcomp doc/finch.1$ doc/pidgin.1$ doc/html pidgin.apspec$ pidgin.desktop$ pidgin.spec$ pidgin-.*.tar.gz pidgin-.*.tar.bz2 pidgin-*.*.*-win32bin$ pidgin/pidgin$ pidgin/pixmaps/emotes/default/24/theme pidgin/pixmaps/emotes/none/theme pidgin/plugins/musicmessaging/music-messaging-bindings.c pidgin/plugins/perl/common/Makefile.PL$ pidgin/win32/pidgin_dll_rc.rc$ pidgin/win32/pidgin_exe_rc.rc$ install-sh libpurple/dbus-bindings.c libpurple/dbus-types.c libpurple/dbus-types.h libpurple/example/nullclient libpurple/gconf/purple.schemas$ libpurple/plugins/dbus-example-bindings.c libpurple/plugins/perl/common/Makefile.PL$ libpurple/plugins/perl/common/const-c.inc libpurple/plugins/perl/common/const-xs.inc libpurple/plugins/perl/common/lib libpurple/purple.h$ libpurple/purple-client-bindings.c libpurple/purple-client-bindings.h libpurple/purple-client-example libpurple/tests/check_libpurple libpurple/version.h$ libpurple/win32/libpurplerc.rc$ libtool local.mak ltmain.sh missing mkinstalldirs po/Makefile.in.in po/POTFILES$ po/missing po/notexist po/pidgin.pot po/stamp-it stamp-h1 win32-install-dir(\.release)? VERSION$