Mercurial > pidgin.yaz
view AUTHORS @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | 62a22a224f27 |
children | de712dc6fecd |
line wrap: on
line source
Pidgin and Finch: The Pimpin' Penguin IM Clients That're Good for the Soul ========================================================================== For a complete list of all contributors, see the COPYRIGHT file. We've got an IRC room now too, #pidgin on irc.freenode.net. Come check us out. Current Developers: ------------------ Daniel 'datallah' Atallah - Developer John 'rekkanoryo' Bailey - Developer Ethan 'Paco-Paco' Blanton - Developer Thomas Butter - Developer Ka-Hing Cheung - Developer Sadrul Habib Chowdhury - Developer Mark 'KingAnt' Doliner - Developer Sean Egan - Developer Casey Harkins - Developer Gary 'grim' Kramlich - Developer Richard 'rlaager' Laager - Developer Richard 'wabz' Nelson - Developer Christopher 'siege' O'Brien - Developer Bartosz Oler - Developer Etan 'deryni' Reisner - Developer Tim 'marv' Ringenbach - Developer Elliott 'QuLogic' Sales de Andrade - Developer Luke 'LSchiere' Schierer - Support Megan 'Cae' Schneider - support/QA Evan Schoenberg - Developer Kevin 'SimGuy' Stange - Developer & Webmaster Will 'resiak' Thompson - Developer Stu 'nosnilmot' Tomlinson - Developer Nathan 'faceprint' Walp - Developer Crazy Patch Writers: ------------------- Felipe 'shx' Contreras Dennis 'EvilDennisR' Ristuccia Peter 'Fmoo' Ruibal Gabriel 'Nix' Schulhof Jorge 'Masca' Villaseñor Retired Developers: ------------------ Herman Bloggs - Win32 Port Jim Duchek <jim@linuxpimps.com> - maintainer Rob Flynn <gaim@robflynn.com> - maintainer Adam Fritzler - libfaim maintainer Christian 'ChipX86' Hammond - Developer & Webmaster Syd Logan - hacker and designated driver [lazy bum] Jim Seymour - XMPP developer Mark Spencer <markster@marko.net> - original author Eric Warmenhoven <eric@warmenhoven.org> - lead developer Retired Crazy Patch Writers: --------------------------- Decklin Foster Peter 'Bleeter' Lawler Robert 'Robot101' McQueen Benjamin Miller Artists: ------- Hylke Bons - Icons Other Contributions: ------------------- Much thanks to Evan Martin <martine@cs.washington.edu> for writing GtkSpell <http://gtkspell.sourceforge.net> responsible for the "Highlight misspelled words" feature and for gtk-nativewin <http://bunny.darktech.org/cvs/gtk-nativewin/> the default GTK+-2.0 engine originally used in our win32 port. ** ORIGINAL LOGO DESIGNED BY: Naru Sundar ** Peter Teichiman <peter@helixcode.com> Larry Ewing Jeramey A. Crawford Thanks to these boys. Peter and Larry managed to stomp out a large list of Mem Leaks. Jeramey found the remaining onees and pointed me to those. Props to the boys at Helix Code. Thanks guys. Nathan Walp A healthy amount of patches for the Jabber plugin Neil Sanchala Wrote most of the Zephyr plugin Arkadiusz Miskiewicz Wrote the Gadu-Gadu plugin David Prater <IM: dRaven43> draven@tcsx.net Log and Colour Button Images Sébastien Carpe <IM: Seb Carpe> Base HTTP Proxy Support Ari Pollak <IM: Ari Pollak> compwiz.dhs.org Resize conversation window patch Decklin Foster Many GUI improvements, other nifty additions and fixes David <IM: CrazyDavy> The neato-bigger text box S D Erle Writing a cool perl script to translate WinAIM lists to gaim BMiller A good collection of stuff. %n for away messages, import winaim lists, pic/text/pic+text for buttons, among others Lance Rocker Improved HTML formatting in logs, plus lots of debugging on *BSD. ergofobe: GNOME Url handler patch Justin M. Ward <justin@yossman.net>: Alphabetical Away Messages patch G. Sumner Hayes <IM: SumnerFool> Security Patches Brian Ryner for a little make file patch :) Ryan C. Gordon - I still think you look like Silent Bob. Elliot Tobin <elliot@bha.udel.edu> Thanks to Jeroen van der Vegt for the initial smiley plugin and images. The OpenQ Team Wrote the QQ plugin (see AUTHORS in the qq directory)