Mercurial > pidgin.yaz
view README.MTN @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | e0bcb8cfda74 |
children |
line wrap: on
line source
If you plan to use Pidgin, Finch and libpurple from our Monotone repository, PLEASE read this message in its entirety! Pidgin, Finch, and libpurple are a fast-moving project with a somewhat regular release schedule. Due to the rate of development, the code in our Monotone repository undergoes frequent bursts of massive changes, often leaving behind brokenness and partial functionality while the responsible developers rewrite some portion of code or seek to add new features. What this all boils down to is that the code in our Monotone repository _WILL_ sometimes be broken. Because of this, we ask that users who are not interested in personally tracking down bugs and fixing them (without a lot of assistance from the developers!) use only released versions. Since releases will be made often, this should not prevent anyone from using the newest, shiniest features -- but it will prevent users from having to deal with ugly development bugs that we already know about but haven't gotten around to fixing. If you are interested in hacking on Pidgin, Finch, and/or libpurple, please check out the information available at: http://developer.pidgin.im By far the best documentation, however, is the documented code. If you have doxygen, you can run "make docs" in the toplevel directory to generate pretty documentation. Otherwise (or even if you do!), the header files for each subsystem contain documentation for the functions they contain. For instance, conversation.h contains documentation for the entire purple_conversation_* API, and account.h contains documentation for the purple_account_* API. If you have questions, please feel free to contact the Pidgin, Finch, and libpurple developers by email at devel@pidgin.im or on IRC at irc.freenode.net in #pidgin. Please do as much homework as you can before contacting us; the more you know about your question, the faster and more effectively we can help! Patches should be posted as Trac tickets at: http://developer.pidgin.im