view doc/Makefile.am @ 23995:85bed17fe5c1

The variable we use to keep track of the watcher of the ssl connection should be unsigned. This isn't really a problem in Pidgin, where we use glib's mainloop and GIOChannels because glib starts assigning the handle IDs sequentially starting from 1. But if an eventloop implementation ever returns a handle ID greater than the largest possible signed integer (2,147,483,647) then we won't be able to remove the watcher because purple_ssl_close() in sslconn.c only removes it if inpa > 0, and since it interprets inpa as a signed value then handles over 2,147,483,647 appear as negative numbers. I stumbled upon this when playing around with libevent, which can use epoll. My implementation generated a random handle ID which was sometimes greater than 2,147,483,647. I don't believe this breaks binary compatibility. And I don't think it breaks source compatibility, but I guess it might depend on what compiler you're using.
author Mark Doliner <mark@kingant.net>
date Thu, 04 Sep 2008 18:04:29 +0000
parents 2aa5a9f47470
children 380e7149a777
line wrap: on
line source

man_MANS = pidgin.1 finch.1

EXTRA_DIST = \
	C-HOWTO.dox \
	PERL-HOWTO.dox \
	SIGNAL-HOWTO.dox \
	TCL-HOWTO.dox \
	TracFooter.html \
	TracHeader.html \
	account-signals.dox \
	blist-signals.dox \
	certificate-signals.dox \
	cipher-signals.dox \
	connection-signals.dox \
	conversation-signals.dox \
	core-signals.dox \
	dbus-server-signals.dox \
	funniest_home_convos.txt \
	finch.1.in \
	gtkaccount-signals.dox \
	gtkblist-signals.dox \
	gtkconv-signals.dox \
	gtklog-signals.dox \
	gtkimhtml-signals.dox \
	gtkrc-2.0 \
	imgstore-signals.dox \
	log-signals.dox \
	notify-signals.dox \
	pidgin.1.in \
	plugin-i18n.dox \
	plugin-ids.dox \
	plugin-signals.dox \
	savedstatus-signals.dox \
	sound-signals.dox \
	the_penguin.txt \
	xfer-signals.dox